feat(agent): add read-only node logs endpoint - #833
Open
Pranav-d33 wants to merge 1 commit into
Open
Conversation
Implements GET /api/v1/nodes/logs?type=PEER&name=<name>&tail=<n> on the Fabric agent, prerequisite for copilot fault-log summarization. Uses docker logs with bounded tail (1..1000, default 200) and maps NotFound to 404. Adds serializer validation and view tests. Signed-off-by: Pranav dhiran <dhiranpranav72@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements GET /api/v1/nodes/logs?type=PEER&name=&tail= on the Fabric agent, prerequisite for copilot fault-log summarization. Uses docker logs with bounded tail (1..1000, default 200) and maps NotFound to 404. Adds serializer validation and view tests.
Part of #813 — prerequisite for @agamatlab's fault-log summarization tool (#3 in the
work split).
What this does
Adds
GET /api/v1/nodes/logs?type=PEER&name=<name>&tail=<n>to the Fabric agent(
src/agents/hyperledger-fabric/). Returns the last N lines of Docker container logsfor a given node.
get_node_logs()inservice.py— same pattern as the existingget_node_status(): readsCRYPTO_CONFIGYAML, resolves container name from orgdomain, calls
container.logs(tail=tail)NodeLogsRequestSerializer— validatestype(PEER/ORDERER),name, andtail(1–1000, default 200)
NodeLogsResponseSerializer—{ logs: str }NodeViewSet.logsaction —@action(detail=False, methods=['get'], url_path='logs'), mapsdocker.errors.NotFoundto 404(200/400/404)
Why separate PR
The logs endpoint is a Fabric agent change with no overlap with the dashboard panel
or the copilot endpoint. Keeping it separate so it can be reviewed and merged
independently without waiting on the larger copilot pieces.
EOF
)"