fix(ci,dom): pin tree-sitter-cli for Sonar; land #56 Window/Document/utility - #758
Merged
Merged
Conversation
…utility SonarCloud QG on main failed C-security on new code because `.github/workflows/ci.yml` ran `npm install -g tree-sitter-cli@^0.25.0` (unlocked version + lifecycle scripts). Pin 0.25.0 and pass `--ignore-scripts` on every tree-sitter-cli install; same flag on the vscode-smoke `npm install`. #56 PR 4 (the original Window/Document/utility inventory): - stdlib/Dom.affine externs for addEventListener/matchMedia/windowOpen/ innerWidth/Height/devicePixelRatio/setTimeout/Interval/clear*, createElement/getElementById/body* / Date.now / Number.isFinite/isNaN / btoa - Deno-ESM `__as_dom*` lowerings + builtins - tests/codegen-deno/dom_window_smoke.{affine,harness.mjs} Native-preview2 (#486 one-way door) is not in this commit. Refs #56
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 21, 2026
Closed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sonar QG on
mainfailed C Security Rating on New Code because.github/workflows/ci.ymlran unlockednpm install -g tree-sitter-cli@^0.25.0(githubactions:S6505 / S8543). Pintree-sitter-cli@0.25.0and pass--ignore-scriptson every install of it; same flag on the vscode-smokenpm install.#56 PR 4 (original Window / Document / utility inventory):
stdlib/Dom.affineexterns for the 11 Window + 7 Document + 4 utility bindings (fetchalready lives in Http)__as_dom*loweringstests/codegen-deno/dom_window_smoke.{affine,harness.mjs}Not in this PR: native-preview2 (#486 one-way door — needs wasm-tools + a compiler in CI, not a drive-by flip). Record-literal attrs remain on #56.
Refs #56