fix(pixi): make #760 smokes compile and run - #765
Merged
Merged
Conversation
PixiUI's extern type List collided with prelude List<T> (kind mismatch on any `use PixiUI`). Rename to UiList. pixi_smoke.harness.mjs now imports smokeIdaptikReach, mocks Assets/renderer/Texture.WHITE, and the three Bun-ESM harnesses pass under node.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Why
#764 landed the idaptik-reached Pixi remainder but the smokes did not compile.
pub extern type ListinPixiUI.affinecollides with preludeList<T>(Kind mismatch: expected KType, got KArrow)pixi_smoke.harness.mjscalledsmokeIdaptikReachwithout importing it and lacked Assets/renderer/WHITE mocksThis PR
List→UiListpixi_smoke,pixisound_smoke,pixiui_smokeharnesses pass under node after--bun-esmcompileToolchain on this machine: ocaml 5.3.0, dune 3.24.2, bun 1.3.14, wasm-tools 1.249.0.