Skip to content

fix(pixi): make #760 smokes compile and run - #765

Merged
hyperpolymath merged 2 commits into
mainfrom
fix/760-pixi-smoke-compile
Sep 21, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
fix/760-pixi-smoke-compile

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Why

#764 landed the idaptik-reached Pixi remainder but the smokes did not compile.

  • pub extern type List in PixiUI.affine collides with prelude List<T> (Kind mismatch: expected KType, got KArrow)
  • pixi_smoke.harness.mjs called smokeIdaptikReach without importing it and lacked Assets/renderer/WHITE mocks

This PR

  • Rename PixiUI extern type ListUiList
  • Wire the harness import + mocks
  • Verified locally: pixi_smoke, pixisound_smoke, pixiui_smoke harnesses pass under node after --bun-esm compile

Toolchain on this machine: ocaml 5.3.0, dune 3.24.2, bun 1.3.14, wasm-tools 1.249.0.

PixiUI's extern type List collided with prelude List<T> (kind mismatch
on any `use PixiUI`). Rename to UiList. pixi_smoke.harness.mjs now
imports smokeIdaptikReach, mocks Assets/renderer/Texture.WHITE, and
the three Bun-ESM harnesses pass under node.
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 4f3d0095-23a4-47a7-b951-987cf7a33639

📥 Commits

Reviewing files that changed from the base of the PR and between afc7f99 and 009b028.

📒 Files selected for processing (4)
  • CHANGELOG.adoc
  • stdlib/PixiUI.affine
  • tests/codegen-deno/pixi_smoke.harness.mjs
  • tests/codegen-deno/pixiui_smoke.affine
 ________________________________________________________
< A spoonful of AI helps the bitter code review go down. >
 --------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit da8bf01 into main Sep 21, 2026
15 of 17 checks passed
@hyperpolymath
hyperpolymath deleted the fix/760-pixi-smoke-compile branch September 21, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant