chore(pages): publish the canonical www bundle, retire the root upload - #104
Merged
Merged
Conversation
The GitHub Pages site was a 404, and two workflows were racing for it while
neither could win: casket-pages.yml uploaded the repository root, which
contains no index.html at all (and would publish dns/, tls/,
security_headers/ and the rest of the repository past the published
boundary), while the Ddraig build was not guaranteed to produce a site.
* retire casket-pages.yml - the repository root is not a site
* the Ddraig build is now best-effort (continue-on-error), so a failed
Idris build can no longer stop the repository publishing
* add www/public/index.html, a placeholder in the same shape as the one
jtv-lang.dev serves, so there is always a servable homepage
* overlay the canonical bundle between the build and the upload:
www/public/ (no-clobber, so a page the SSG did produce always wins) and
www/.well-known/, so /.well-known/security.txt is reachable - RFC 9116,
and the RSR check on www/.well-known/security.txt
Additive only: nothing the SSG produces is replaced.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub Pages site was a 404, and two workflows were racing for it while
neither could win: casket-pages.yml uploaded the repository root, which
contains no index.html at all (and would publish dns/, tls/,
security_headers/ and the rest of the repository past the published
boundary), while the Ddraig build was not guaranteed to produce a site.
Idris build can no longer stop the repository publishing
jtv-lang.dev serves, so there is always a servable homepage
www/public/ (no-clobber, so a page the SSG did produce always wins) and
www/.well-known/, so /.well-known/security.txt is reachable - RFC 9116,
and the RSR check on www/.well-known/security.txt
Additive only: nothing the SSG produces is replaced.
Verified before pushing: the workflow YAML parses, the overlay step sits between the build and the upload, and the overlay script was extracted from the YAML and executed against three cases — SSG produced nothing (placeholder index and
/.well-known/security.txtboth published), SSG produced a real page (not clobbered), and the Jekyll_site/wwwcase (bundle source removed). A leak check confirmsdns/and the other non-published subtrees never reach_site.Note: the estate is carrying roughly 3,200 queued Actions runs from earlier mass pushes, so this will not deploy immediately. That is a queue backlog, not a failure of this change.