fix(pages): publish .well-known — the upload was stripping it - #105
Merged
Merged
Conversation
The canonical bundle was reaching `_site` and then being deleted on the way out. `actions/upload-pages-artifact` defaults to `include-hidden-files: false`, and its archiving step is a `tar` that carries `--exclude=.[^/]*`. That pattern matches every top-level entry beginning with a dot, so `.well-known/` was stripped from the artifact after the overlay step had placed it correctly. Evidence from the last run of `pages.yml` — the job's own output: ``` published tree: _site _site/.well-known _site/.well-known/ai.txt _site/.well-known/humans.txt _site/.well-known/security.txt ``` ...followed by a successful upload and a successful deploy, and then a 404 at `/.well-known/security.txt`. The overlay is not at fault; the upload is. `include-hidden-files: true` publishes dot-entries deliberately. `.git` and `.github` remain excluded by the action regardless. Confirmed by contrast: `ubicity`, the only repository in the estate that hand-rolls its `tar` (for SHA-pinning reasons), is the only one serving `security.txt`.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canonical bundle was reaching
_siteand then being deleted on the way out.actions/upload-pages-artifactdefaults toinclude-hidden-files: false, andits archiving step is a
tarthat carries--exclude=.[^/]*. That patternmatches every top-level entry beginning with a dot, so
.well-known/wasstripped from the artifact after the overlay step had placed it correctly.
Evidence from the last run of
pages.yml— the job's own output:...followed by a successful upload and a successful deploy, and then a 404 at
/.well-known/security.txt. The overlay is not at fault; the upload is.include-hidden-files: truepublishes dot-entries deliberately..gitand.githubremain excluded by the action regardless.Confirmed by contrast:
ubicity, the only repository in the estate thathand-rolls its
tar(for SHA-pinning reasons), is the only one servingsecurity.txt.