fix: rank exact matches above popularity factor - #142
Merged
Conversation
This was referenced Jun 2, 2026
vaxerski
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an exact name match exists, it is sometimes not the top result (see #138). The fuzzy score is
base * lenFactor * popFactor, where match quality (base * lenFactor) is capped at 1.0 for an exact match, butpopFactor = 1 + 0.08 * log1p(freq)is an unbounded multiplier. A frequently-launched partial match can therefore outrank a freshly-installed exact match.Fix
Exact (case-insensitive, whole-string) matches now occupy a reserved score band above any achievable fuzzy score, so a popular partial match can no longer outrank them. Popularity still orders everything else, and still breaks ties among exact matches.