Handle paths in XDG_DATA_DIRS with trailing slashes - #26
Closed
tomaspinho wants to merge 1 commit into
Closed
Conversation
Author
|
Disclaimer: not a c++ dev, so style may be off. The fix works. |
vaxerski
reviewed
Oct 28, 2025
vaxerski
left a comment
vaxerski
left a comment
Member
There was a problem hiding this comment.
this is unsafe, maybe just convert into std::filesystem::path?
Author
|
Thanks for the review @vaxerski. Just re-implemented in a safer way as per your suggestion. |
|
Thanks @tomaspinho as per comment: #19 (comment) I wonder if there can be still more to it? |
Member
|
can you guys check my fix over at #27? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for: #19 (comment)