core: migrate to hyprtoolkit - #288
Conversation
|
THIS THAT DONT WORK
THIS THAT WORK
WILL TEST LATER
|
No, that's intentional.
oops.
they are there I just didnt mention them in the mr
I've noticed some issues there too, I'll check. |
|
paths fixed. Outputs fixed in hyprtoolkit (git) |
...but why? yeah wallpapers appears on both monitors now. Will be in ZH at ~22.00 and check 21:9 there |
|
zh? enjoy your china trip |
|
I'm loving the chicken here yeah btw 21:9 seems fine. I got a crash when disconnecting the monitor with shikane running (which is supposed to turn my laptop back on after I disconnect the external monitor, but isn't doing that) so maybe you can replicate this by disabling the only active monitor? Cause that's pretty muxh what's happeninf |
|
cant repro, debug stacktrace maybe? |
|
fit_mode no worky because it's hard coded to cover in Unplugging a monitor and plugging it back again doesn't create a wallpaper for it. I assume that's because monitor state isn't removed from hyprtoolkit built against hyprwm/hyprtoolkit@34a758f wayland loghyprpaper log (removed dmabuf format spam) |
|
should be both fixed, pls check |
Yep, both work now |
|
huh, it shouldnt, wut can you post the images separately github doesnt wanna show em when I click on them |
|
|
hm, hyprtoolkit does linear sampling, IIRC with hyprpaper on cairo we did "good" aa, but this isn't really something we do in toolkit. To be fair, I barely see the difference in these. |
|
I'ven't used hyprtoolkit, but I'm curious why is it needed to have null and background elements instead of just slapping the image & splash onto the root element |
|
null is just for my convenience |
|
IPC re-added, but with hyprwire. This means old hyprctl commands will no longer work. See hyprwm/Hyprland#12537 New syntax: fit mode optional. |
|
your entier family stoobid firstly its PATH not FILE secondly ipc requires a full path |
|
here it will now resolve in hyprctl check the hyprland mr |
|
anything else outstanding? |
|
Seg fault in configbacktrace#0 0x000000000044189c in __gnu_cxx::__normal_iterator<Hyprutils::Memory::CSharedPointer<CHyprpaperCoreManagerObject>*, std::vector<Hyprutils::Memory::CSharedPointer<CHyprpaperCoreManagerObject>, std::allocator<Hyprutils::Memory::CSharedPointer<CHyprpaperCoreManagerObject> > > >::__normal_iterator (this=<optimized out>, __i=<error reading variable: Cannot access memory at address 0x30>)
at /usr/include/c++/15.2.1/bits/stl_iterator.h:1059
#1 std::vector<Hyprutils::Memory::CSharedPointer<CHyprpaperCoreManagerObject>, std::allocator<Hyprutils::Memory::CSharedPointer<CHyprpaperCoreManagerObject> > >::begin (this=0x30)
at /usr/include/c++/15.2.1/bits/stl_vector.h:999
#2 0x000000000043c63f in IPC::CSocket::onNewDisplay (this=0x0, sv="HDMI-A-2") at /home/spicy/git/hyprpaper/src/ipc/IPC.cpp:138
m = @0x1d8247d0: {impl_ = 0x1cb20530, m_data = 0x1cb19bd0}
#3 0x0000000000449b69 in CUI::registerOutput (this=0x1caa25e0, mon=...) at /home/spicy/git/hyprpaper/src/ui/UI.cpp:72
#4 0x0000000000449eaa in CUI::run (this=0x1caa25e0) at /home/spicy/git/hyprpaper/src/ui/UI.cpp:94
m = @0x1d8247d0: {impl_ = 0x1cb20530, m_data = 0x1cb19bd0}
PENABLEIPC = {p_ = 0x1ca82e70}
MONITORS = std::vector of length 1, capacity 1 = {{impl_ = 0x1cb20530, m_data = 0x1cb19bd0}}
#5 0x0000000000445fac in main (argc=1, argv=0x7ffc72bcb788, envp=0x7ffc72bcb798) at /home/spicy/git/hyprpaper/src/main.cpp:37
parser = {m_impl = {impl_ = 0x1cab16f0}} |
|
thanks fixed |
|
I think this is more of of a hyprwire issue but If I send at least two valid request at the same time, hyprpaper will exit with an out of range error. hyprctl hyprpaper wallpaper 'WAYLAND-1, [wallpaper path]' & hyprctl hyprpaper wallpaper ', [wallpaper path]'backtrace |
|
I'll check it |
|
fixed in wire :) |
|
Thanks! these are all issues I could find, good luck with the release |
|
thanks! |
yues
its fixed on git (toolkit) |
|
Are you planning a release for this now that it's been merged, or wanting to re-implement preloading and the related IPC commands first? I'm pretty new to the hypr ecosystem but I'd be willing to give it a go I'm running the git packages on Arch - I usually use waypaper as a frontend and to automate cycling through wallpapers to recreate the Windows slideshow option. I've submitted a PR that will allow it to work with hyprpaper-git without breaking support for the current version of Hyprpaper. |
|
vaxry is probably waiting to drop hyprland 0.53 first before a hyprpaper release, due to the ipc changes |
|
yes. I don't want hyprctl hyprpaper to break |







rewrites everything from scratch with hyprtoolkit.
New config:
wallpaper { monitor = ... # wildcard is still empty fit_mode = cover # default path = ... }TODO:
Wiki: hyprwm/hyprland-wiki#1303