Skip to content

fix(config): support * as wildcard monitor for default wallpapers - #315

Merged
vaxerski merged 1 commit into
hyprwm:mainfrom
jmylchreest:bug/non-unique-paths-unique-monitors
Jan 7, 2026
Merged

fix(config): support * as wildcard monitor for default wallpapers#315
vaxerski merged 1 commit into
hyprwm:mainfrom
jmylchreest:bug/non-unique-paths-unique-monitors

Conversation

@jmylchreest

Copy link
Copy Markdown
Contributor

Add isWildcard() helper to treat both empty string and "*" as wildcards when matching wallpaper settings to monitors.

This works around a limitation in hyprlang where listKeysForSpecialCategory() skips entries with empty string keys (due to isStatic check in retrieveKeysForCat), causing configs like:

wallpaper {
    monitor =
    path = /path/to/image.png
}

to be silently ignored. Users should now use "monitor = *" instead.

Add isWildcard() helper to treat both empty string and "*" as wildcards
when matching wallpaper settings to monitors.

This works around a limitation in hyprlang where listKeysForSpecialCategory()
skips entries with empty string keys (due to isStatic check in retrieveKeysForCat),
causing configs like:

    wallpaper {
        monitor =
        path = /path/to/image.png
    }

to be silently ignored. Users should now use "monitor = *" instead.
@vaxerski

vaxerski commented Jan 5, 2026

Copy link
Copy Markdown
Member

yeah but the limitation got fixed, no?

@jmylchreest

Copy link
Copy Markdown
Contributor Author

Correct, I actually raised this before the other fix PR, but thought I'd leave this here for consideration (or just reject)

@vaxerski vaxerski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont mind really, no monitor will be called *

@vaxerski
vaxerski merged commit feafd06 into hyprwm:main Jan 7, 2026
1 check passed
noisesfromspace added a commit to noisesfromspace/stylix that referenced this pull request Jan 13, 2026
Added in hyprwm/hyprpaper#315 also adds
mkDefault in order to allow users to override values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants