Commit 0b813f4
fix(privacy): stop Android backup restoring optional-service consent
`android:allowBackup` was never declared, so it defaulted to true. On an
emulator, `adb uninstall` followed by `adb install` of the v3.22.2-b release
skipped onboarding entirely and every optional service — catalogs, radio/TV
streaming and GitHub update checks — came back already enabled, because
Android restored the previous install's preferences.
That makes three statements untrue: the Optional Services screen ("off until
you enable them"), docs/ORIENTATION.md ("a fresh install starts with
everything off") and the release notes ("every outbound connection sits
behind a switch that ships off"). A driver who reinstalls, or restores onto a
new head unit, gets streaming and update checking without being asked.
It also explains the runtime error seen on that first launch:
flutter_secure_storage ciphertext was restored without its Android Keystore
key, which never leaves the device — "Key mismatch detected during cipher
initialization".
Backup is now off on both paths. `allowBackup="false"` covers cloud backup on
every API level; res/xml/data_extraction_rules.xml is required as well
because on API 31+ device-to-device transfer is governed there, not by
allowBackup. Verified in the built APK: allowBackup=false and
dataExtractionRules resolving to a compiled resource.
Trade-off, taken deliberately: favorites, themes and settings no longer
migrate to a new device. They live in the same FlutterSharedPreferences file
as `optional_services.v1` and Android's backup rules are file-granular, so
consent cannot be excluded on its own. Silently inheriting consent is the
worse outcome for an app that can actuate a vehicle. Keeping migration would
mean moving the consent key into its own preferences file.
test/architecture/backup_disabled_test.dart guards it: the attribute defaults
to true when absent, so deleting the line is a silent regression rather than
a build failure.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AjhsQbfGjJw2V8j2WmRXpN1 parent edd2489 commit 0b813f4
3 files changed
Lines changed: 149 additions & 0 deletions
File tree
- android/app/src/main
- res/xml
- test/architecture
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
156 | 165 | | |
157 | 166 | | |
158 | 167 | | |
159 | 168 | | |
160 | 169 | | |
| 170 | + | |
| 171 | + | |
161 | 172 | | |
162 | 173 | | |
163 | 174 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
0 commit comments