Skip to content

Commit 965fa97

Browse files
committed
fix(release): tag releases v<version>, not ilink-v<version>
The first real release built and signed correctly, then failed on its last step: tag: ilink-v3.22.1-b test "$RELEASE_TAG" = "v$VERSION_NAME" # expected v3.22.1-b release-please emits component-prefixed tags when `package-name` is set, so it created `ilink-v3.22.1-b` while the workflow asserts a bare `v<versionName>`. The workflow assertion is the one that is right, and relaxing it would have been the wrong fix. `GitHubReleaseSource` applies the identical rule on the device: tag != 'v$name' || ... -> return null So a component-prefixed release builds and publishes happily and is then silently refused by every installed app — an update that looks shipped and reaches nobody. The build failing here is the guard doing its job. `include-component-in-tag: false` makes the tag `v<version>`, which is what the workflow, the OTA client and RELEASE.md all already expect. The mis-tagged `ilink-v3.22.1-b` tag and its release are deleted; they carried no assets, since the failure happened before the attach step. This lands as a fix so release-please cuts the next version with the corrected tag.
1 parent 7d3fa91 commit 965fa97

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

release-please-config.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"release-type": "dart",
66
"package-name": "ilink",
77
"include-v-in-tag": true,
8+
"include-component-in-tag": false,
89
"bump-minor-pre-major": false,
910
"changelog-path": "CHANGELOG.md",
1011
"changelog-sections": [

0 commit comments

Comments
 (0)