Refactor project structure and add dotenv database configuration by iJosueeh · Pull Request #2 · iJosueeh/meditrack

iJosueeh · 2026-03-30T15:29:09Z

No description provided.

… support

Copilot

Pull request overview

Refactors the application’s package/module structure and introduces environment-based database configuration (dotenv) along with a local SQL Server docker-compose setup.

Changes:

Moved the JavaFX Application entrypoint into com.utp.meditrackapp.core and updated launch configuration.
Added DatabaseConfig (dotenv + JDBC URL construction) and a Navigation helper for feature-based FXML loading.
Added SQL Server + Adminer docker-compose.yml, plus .env template/ignore rules.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`src/main/java/module-info.java`	Adds module dependencies/exports for new core structure and DB usage.
`src/main/java/com/utp/meditrackapp/core/App.java`	Renames/moves the JavaFX `Application` class.
`src/main/java/com/utp/meditrackapp/Launcher.java`	Updates launcher to start the new `App` entrypoint.
`src/main/java/com/utp/meditrackapp/core/config/DatabaseConfig.java`	Introduces dotenv-driven SQL Server connection configuration.
`src/main/java/com/utp/meditrackapp/core/config/Navigation.java`	Adds a simple navigation utility for loading feature FXML views.
`pom.xml`	Adds dotenv + MS SQL JDBC dependencies; updates JavaFX plugin main class.
`docker-compose.yml`	Adds SQL Server container and Adminer UI for local DB usage.
`.gitignore`	Ignores `.env` to prevent committing secrets.
`.env.template`	Provides example DB environment variables for local setup.

Comments suppressed due to low confidence (1)

src/main/java/com/utp/meditrackapp/core/App.java:15

App.class.getResource("hello-view.fxml") resolves relative to com/utp/meditrackapp/core/, but the existing FXML is located at src/main/resources/com/utp/meditrackapp/hello-view.fxml. This will return null and fail at runtime. Use an absolute resource path (e.g., starting with /com/utp/meditrackapp/) or move the FXML into the core resource package to match the lookup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-30T15:33:27Z

    requires javafx.fxml;
-
+    requires io.github.cdimascio.dotenv.java;
+    requires java.sql;


The app is a JPMS module (module-info.java) and uses a SQL Server JDBC URL, but the SQL Server driver module isn’t required. On the module path this can prevent the driver from being resolved/loaded and lead to No suitable driver at runtime. Add the appropriate requires for the MS SQL driver module (or ensure the runtime adds it as a root module).

Suggested change

requires java.sql;

requires java.sql;

requires com.microsoft.sqlserver.jdbc;

Copilot · 2026-03-30T15:33:28Z

+        return instance;
+    }
+
+    public Connection getConnectionUrl() throws SQLException {


Method name getConnectionUrl() is misleading: it returns a Connection, not a URL. Rename it to something like getConnection() (and if needed, expose the URL via a separate getConnectionUrl() that returns String).

Suggested change

public Connection getConnectionUrl() throws SQLException {

public String getConnectionUrl() {

return this.connectionUrl;

}

public Connection getConnection() throws SQLException {

Copilot · 2026-03-30T15:33:28Z

+        this.connectionUrl = String.format(
+                "jdbc:sqlserver://%s:%s;databaseName=%s;user=%s;password=%s;encrypt=true;trustServerCertificate=true;",
+                dbHost, dbPort, dbName, dbUser, dbPassword


The connection string hard-codes trustServerCertificate=true. This disables proper TLS certificate validation and is unsafe as a default. Make this configurable via env (with a safe default) or restrict it to explicit local-dev configuration.

Suggested change

this.connectionUrl = String.format(

"jdbc:sqlserver://%s:%s;databaseName=%s;user=%s;password=%s;encrypt=true;trustServerCertificate=true;",

dbHost, dbPort, dbName, dbUser, dbPassword

// Determine trustServerCertificate value in a configurable and safe way.

// Prefer explicit env configuration; otherwise, only default to "true" for local/dev environments.

String trustServerCertificate = dotenv.get("DB_TRUST_SERVER_CERTIFICATE");

if (trustServerCertificate == null || trustServerCertificate.isBlank()) {

String appEnv = dotenv.get("APP_ENV");

if (appEnv != null && (

"local".equalsIgnoreCase(appEnv)

|| "development".equalsIgnoreCase(appEnv)

|| "dev".equalsIgnoreCase(appEnv))) {

trustServerCertificate = "true";

} else {

trustServerCertificate = "false";

}

}

this.connectionUrl = String.format(

"jdbc:sqlserver://%s:%s;databaseName=%s;user=%s;password=%s;encrypt=true;trustServerCertificate=%s;",

dbHost, dbPort, dbName, dbUser, dbPassword, trustServerCertificate

Copilot · 2026-03-30T15:33:28Z

+            Scene scene = new Scene(root);
+            primaryStage.setScene(scene);
+            primaryStage.show();


primaryStage can be null if setStage() wasn’t called before loadFeature(), which will throw at primaryStage.setScene(...). Add an explicit null check with a clear error/exception before using the stage.

Copilot · 2026-03-30T15:33:29Z

+        } catch (NullPointerException error) {
+            System.err.println("Error: No se encontró el archivo FXML en la ruta especificada.");
+        }


Catching NullPointerException here will also swallow unrelated NPEs (e.g., from primaryStage being null) and makes debugging harder. Prefer explicit null checks for the resource (getResource(...)) and stage, and throw/log a targeted error when either is missing.

Copilot · 2026-03-30T15:33:29Z

+      - "1433:1433"
+    environment:
+      - ACCEPT_EULA=Y
+      - MSSQL_SA_PASSWORD=${DB_PASSWORD}


The compose file only configures the sa password (MSSQL_SA_PASSWORD), but the application expects DB_USER/DB_NAME from dotenv. Unless .env sets DB_USER=sa and a DB that already exists, connections will fail. Consider aligning .env.template defaults (e.g., DB_USER=sa, DB_NAME=master) or adding an init step/script to create the database and user used by the app.

Suggested change

- MSSQL_SA_PASSWORD=${DB_PASSWORD}

- MSSQL_SA_PASSWORD=${DB_PASSWORD}

- DB_USER=sa

- DB_NAME=master

iJosueeh added 2 commits March 29, 2026 23:03

refactor project structure and add database configuration with dotenv…

bede14b

… support

refactor project structure and add database configuration with dotenv…

cd06b1a

… support

iJosueeh requested review from Copilot and kath144 March 30, 2026 15:29

Copilot started reviewing on behalf of iJosueeh March 30, 2026 15:29 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

iJosueeh merged commit 0320ef1 into main Mar 30, 2026
9 checks passed

iJosueeh deleted the features/core-docker branch March 30, 2026 15:41

kath144 approved these changes Mar 30, 2026

View reviewed changes

Navigation Menu

Refactor project structure and add dotenv database configuration - #2

Refactor project structure and add dotenv database configuration#2
iJosueeh merged 2 commits into
mainfrom
features/core-docker

iJosueeh commented Mar 30, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	requires java.sql;
	requires java.sql;
	requires com.microsoft.sqlserver.jdbc;

-    public Connection getConnectionUrl() throws SQLException {
+    public String getConnectionUrl() {
+        return this.connectionUrl;
+    }
+    public Connection getConnection() throws SQLException {

-        this.connectionUrl = String.format(
-                "jdbc:sqlserver://%s:%s;databaseName=%s;user=%s;password=%s;encrypt=true;trustServerCertificate=true;",
-                dbHost, dbPort, dbName, dbUser, dbPassword
+        // Determine trustServerCertificate value in a configurable and safe way.
+        // Prefer explicit env configuration; otherwise, only default to "true" for local/dev environments.
+        String trustServerCertificate = dotenv.get("DB_TRUST_SERVER_CERTIFICATE");
+        if (trustServerCertificate == null || trustServerCertificate.isBlank()) {
+            String appEnv = dotenv.get("APP_ENV");
+            if (appEnv != null && (
+                    "local".equalsIgnoreCase(appEnv)
+                            || "development".equalsIgnoreCase(appEnv)
+                            || "dev".equalsIgnoreCase(appEnv))) {
+                trustServerCertificate = "true";
+            } else {
+                trustServerCertificate = "false";
+            }
+        }
+        this.connectionUrl = String.format(
+                "jdbc:sqlserver://%s:%s;databaseName=%s;user=%s;password=%s;encrypt=true;trustServerCertificate=%s;",
+                dbHost, dbPort, dbName, dbUser, dbPassword, trustServerCertificate

Conversation

iJosueeh commented Mar 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants