fix(team): persist confirmed model changes - #3581
Open
Inference1 wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Author
|
@yunlzheng Would you please review this pr? |
Author
|
@geeknees Would you please review this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Persists a Team member model only after the ACP runtime confirms the requested switch. The Team header now calls the Team model endpoint through a success callback, while rejected or timed-out runtime changes leave the persisted Team roster untouched.
The persisted Team model is also used as the selector fallback during reloads, with regression coverage across the IPC bridge, selector, and model hook.
Closes #3566
Type of Change
fix— Bug fix (non-breaking change which fixes an issue)feat— New feature (non-breaking change which adds functionality)perf— Performance improvementrefactor— Code restructuring (no behavior change)docs— Documentation updateAtomic PR Checklist (Rule 1)
<type>(<scope>): <subject>(English)Local Checks (Rule 3)
bun run format— formatting passesbun run lint— no lint errors (skip if no.ts/.tsxchanged)bunx tsc --noEmit— no type errors (skip if no.ts/.tsxchanged)bunx vitest run— tests passbun run i18n:types+node scripts/check-i18n.js) — only ifsrc/renderer/,locales/, orsrc/common/config/i18n/changed; N/A otherwiseRuntime Verification
Screenshots
N/A — no visual changes.
Additional Context
Depends on iOfficeAI/AionCore#613 for the Team persistence endpoint and background-message behavior reported in #3566.