fix(pptx): honor noFill text outlines in HTML preview - #349
Open
y4ho0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
a:noFillScope
This addresses only the
a:rPr/a:ln/a:noFilltext-outline item in #341. The connector, inherited alignment, and equation-rendering items in that issue remain out of scope.Refs #341
Validation
dotnet build src/officecli/officecli.csproj --configuration Release --no-restore— passed with 0 errors (one pre-existing nullable warning inExcelHandler.SheetShift.cs)sample.pptxfrom [PPTX] view html does not preserve several drawing, text, and equation properties #341: before this change the affected run emitted a black-webkit-text-stroke; after the change it emits no text stroke-webkit-text-stroke:1.33px #FF0000git diff --check