repin: rebuild the package from upstream c47b1284 (pstack v0.15.5) by iap · Pull Request #70 · iap/pstack-hermes

iap · 2026-10-06T00:07:20Z

Pull request

What changed

Re-pin to upstream c47b1284 (pstack v0.15.5): 36 dead converter anchors re-anchored or pruned, F16 retired, pstack/ rebuilt (45 -> 47 skills).

Affected surface

tooling (tools/, CI, docs)
generated package (pstack/) — requires a rebuild from the current pin

Provenance — required if `pstack/` changed

source_commit: c47b12849e43f18d5c374c7069c744cc55b0ea00
converter: convert.py (sha256[:16]=fd473325d5dab56a)

Verification

uv run --frozen ruff check tools
All checks passed!
uv run --frozen pytest -q
94 passed in 14.73s
package rebuilt from the pin and git status shows the intended pstack/ diff
worktree before commit: 153 paths changed from main - .github workflows x4 (UPSTREAM_PIN -> c47b1284, lock-step by tools/check_pins.py) - docs/ADAPTATIONS.md (re-pin log + row updates), CHANGELOG.md - tools/convert.py + tools/validate.py (anchor maps, F16 retirement) - pstack/ regenerated from c47b1284: version 0.15.5 (+2 principle skills = 47 total, refreshed prose model defaults, reflect 4-column table, budget key in the setup-written panel shape)
poteto-mode scripts green, if touched (bun run test + bun run typecheck)
package scripts changed with upstream content; suite runs in CI: the `poteto-mode-scripts` job executes it against the rebuilt package. (no bun toolchain on the authoring machine; not simulated locally)

Notes for reviewers

Converter audit at the new pin: 36 dead anchors -> 0; every change is anchored in docs/ADAPTATIONS.md section 4 (re-pin log) plus the updated section-1 rows.
F16 retirement: upstream now ships the slug-agnostic check-plan.mjs regex and the <swarm workers model> placeholder, so the port's env-override transform was removed; validate.py asserts the upstream shapes (bound to this pin bump by design).
Triage correction recorded: upstream deleted no skills/orchestrate — no such skill existed at either pin; only the poteto-mode/playbooks/orchestrate.md playbook, present at both.
The shipped panel keeps its vendor-qualified verified slugs (the validator requires vendor/model format); upstream's short defaults remain in prose as fallback documentation.
Additional gates run: tools/validate.py (static PASS; gold manifest PASS; gold load PASS), tools/scanner_gate.py (clean, 132 files), tools/dist_checkout_check.py --source-tree (133 text LF-only + 1 binary byte-identical), actionlint + check_action_shell.py clean, tools/check_pins.py lock-step across all four workflows.

…7b1284 Converter audit at the new pin: 36 dead anchors -> 25 after this batch. Old-pin build intentionally no longer green (F16 gate now asserts the c47b1284 shapes; the pin bump rides with the remaining anchors).

Converter now runs green at the new pin: anchor audit 36 -> 0 dead. Pruned entries superseded upstream (T9 create-skill bullet, T11 path fixes now handled by T8, T11 /tmp instruction removed upstream).

Re-pin per docs/ADAPTATIONS.md section 4: - 36 dead converter anchors re-anchored or pruned for the new pin (T8-T14 + delegation); converter audit green at c47b1284. - F16 retired: upstream ships the slug-agnostic check-plan.mjs regex and the <swarm workers model> placeholder; validate.py asserts the upstream shapes. - reflect's 4-column reviewer table adopted; the setup-written panel shape gains the upstream budget key. - Two new upstream principles ported: 45 -> 47 skills. - UPSTREAM_PIN bumped in all four workflows (tools/check_pins.py lock-step). - pstack/ rebuilt from c47b1284; validate.py, scanner gate, dist-checkout, pytest (94), ruff, actionlint all green. Co-authored-by: Hermes <iap@users.noreply.github.com>

iap · 2026-10-06T00:07:30Z

@macroscope-app review

macroscopeapp · 2026-10-06T00:07:41Z

Manual reviews triggered for commit 0412122:

^{All prior checks · these links stay valid even if you push more commits.}

macroscopeapp · 2026-10-06T00:07:44Z

Review started; results will be posted in the check runs.

macroscopeapp · 2026-10-06T00:11:07Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This repin substantially changes the shipped agent workflow surface, including new principle skills, model-budget behavior, delegation guidance, and removal of an existing critique path across 105 files. The scope is broader than a mechanical rebuild or minor configuration change, and the generated-index concern further merits human review.

Not approved because:

automatic approval is not enabled for this workspace
1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

^{Enable approvability here. Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}

- F16b: tighten the upstream lane regex so a whitespace-only slug cannot pass; the validate F16 gate now asserts the non-whitespace form. - reflect: lens rows carry all four table cells and quote the exact panel keys (`reflect judgment, divergent, synthesizer` / `reflect tooling`); the why-investigators / why-synthesizer lines likewise name their keys. - T8 extension: principle-fix-root-causes guard wording; the test-behavior-not-implementation five-shape list corrected (toBeTruthy, toBeInstanceOf, toBeGreaterThan(0), toEqual([]), toHaveLength(0) do fail on undefined); setup-pstack budget note for fresh configurations; auto-selector cleanup across skills; how Step 2b direct-explain grounding instruction; the stale `how critics` retired-role example dropped. - pstack/ rebuilt; validate / scanner / dist-checkout / pytest / ruff / actionlint all green. Co-authored-by: Hermes <iap@users.noreply.github.com>

Co-authored-by: Hermes <iap@users.noreply.github.com>

iap · 2026-10-06T00:19:03Z

@macroscope-app review

macroscopeapp · 2026-10-06T00:19:17Z

Review started; results will be posted in the check runs.

Co-authored-by: Hermes <iap@users.noreply.github.com>

…2 fixes Co-authored-by: Hermes <iap@users.noreply.github.com>

iap · 2026-10-06T00:24:12Z

@macroscope-app review

macroscopeapp · 2026-10-06T00:24:27Z

Review started; results will be posted in the check runs.

macroscopeapp · 2026-10-06T00:25:36Z

@@ -0,0 +1,25 @@
+---
+name: principle-test-behavior-not-implementation
+description: "Apply when you write, change, or keep a test. Call the code the way its users do and assert the result they observe against a literal expected value. If the test would still pass when every imported function returns undefined, rewrite the assertion or delete the test."


🟡 Medium principle-test-behavior-not-implementation/SKILL.md:3

poteto-agent will not discover principle-test-behavior-not-implementation during test-writing tasks because this new leaf is absent from poteto-mode's inline Principles index, and this package contains no other reference to the slug. Add the slug to that index so agents are instructed to read and apply the principle.

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file @pstack/skills/principle-test-behavior-not-implementation/SKILL.md around line 3: `poteto-agent` will not discover `principle-test-behavior-not-implementation` during test-writing tasks because this new leaf is absent from `poteto-mode`'s inline Principles index, and this package contains no other reference to the slug. Add the slug to that index so agents are instructed to read and apply the principle.

…legation case) Co-authored-by: Hermes <iap@users.noreply.github.com>

iap · 2026-10-06T00:29:31Z

@macroscope-app review

macroscopeapp · 2026-10-06T00:29:44Z

Review started; results will be posted in the check runs.

Co-authored-by: Hermes <iap@users.noreply.github.com>

iap · 2026-10-06T00:34:31Z

@macroscope-app review

macroscopeapp · 2026-10-06T00:34:42Z

Review started; results will be posted in the check runs.

iap · 2026-10-06T00:54:32Z

@macroscope-app review

macroscopeapp · 2026-10-06T00:54:49Z

Review started; results will be posted in the check runs.

iap and others added 3 commits October 5, 2026 15:33

wip(repin): re-anchor T9/T11/T12/T13/T14 + delegation for c47b1284

6d69d01

Converter now runs green at the new pin: anchor audit 36 -> 0 dead. Pruned entries superseded upstream (T9 create-skill bullet, T11 path fixes now handled by T8, T11 /tmp instruction removed upstream).

github-actions Bot added documentation Documentation tooling Converter, validator, CI tooling skills Workflow/mode skill changes pstack-core Core manifest/config changes cursor-dual-load Cursor dual-load surface (inert on hermes) principles Principle skill changes labels Oct 6, 2026

macroscopeapp Bot reviewed Oct 6, 2026

View reviewed changes

iap and others added 3 commits October 5, 2026 17:17

repin: drop the last stale auto selector mention (setup-pstack step 3b)

999c1e9

Co-authored-by: Hermes <iap@users.noreply.github.com>

repin: drop the last stale auto selector mention (setup-pstack step 3b)

ffb4e6e

Co-authored-by: Hermes <iap@users.noreply.github.com>

macroscopeapp Bot reviewed Oct 6, 2026

View reviewed changes

Comment thread tools/validate.py Outdated

Comment thread pstack/skills/principle-test-behavior-not-implementation/SKILL.md Outdated

macroscopeapp Bot reviewed Oct 6, 2026

View reviewed changes

Comment thread pstack/skills/principle-test-behavior-not-implementation/SKILL.md Outdated

iap and others added 2 commits October 5, 2026 17:23

repin: round-2 review fixes (exact F16 gate line; test-shape nuances)

c4f904e

Co-authored-by: Hermes <iap@users.noreply.github.com>

repin: restore the raw test-shape anchor; rebuild package with round-…

6a17b99

…2 fixes Co-authored-by: Hermes <iap@users.noreply.github.com>

macroscopeapp Bot reviewed Oct 6, 2026

View reviewed changes

Comment thread tools/convert.py

macroscopeapp Bot reviewed Oct 6, 2026

View reviewed changes

repin: round-3 review fixes (principle index membership; lowercase de…

99cf148

…legation case) Co-authored-by: Hermes <iap@users.noreply.github.com>

macroscopeapp Bot reviewed Oct 6, 2026

View reviewed changes

Comment thread tools/convert.py Outdated

repin: drop the contradictory migration sentence (setup-pstack step 1)

0412122

Co-authored-by: Hermes <iap@users.noreply.github.com>

iap merged commit dd21528 into main Oct 6, 2026
12 checks passed

iap deleted the repin/upstream-c47b1284 branch October 6, 2026 00:58

Conversation

iap commented Oct 6, 2026

Pull request

What changed

Affected surface

Provenance — required if pstack/ changed

Verification

Notes for reviewers

Uh oh!

iap commented Oct 6, 2026

Uh oh!

macroscopeapp Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macroscopeapp Bot commented Oct 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macroscopeapp Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

iap commented Oct 6, 2026

Uh oh!

macroscopeapp Bot commented Oct 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iap commented Oct 6, 2026

Uh oh!

macroscopeapp Bot commented Oct 6, 2026

Uh oh!

Uh oh!

macroscopeapp Bot Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

iap commented Oct 6, 2026

Uh oh!

macroscopeapp Bot commented Oct 6, 2026

Uh oh!

Uh oh!

iap commented Oct 6, 2026

Uh oh!

macroscopeapp Bot commented Oct 6, 2026

Uh oh!

iap commented Oct 6, 2026

Uh oh!

macroscopeapp Bot commented Oct 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Provenance — required if `pstack/` changed

macroscopeapp Bot commented Oct 6, 2026 •

edited

Loading

macroscopeapp Bot commented Oct 6, 2026 •

edited

Loading