Skip to content

Fix various build issues - #261

Merged
ibarrond merged 4 commits into
masterfrom
dev
Aug 20, 2025
Merged

Fix various build issues#261
ibarrond merged 4 commits into
masterfrom
dev

Conversation

@AlexanderViand

Copy link
Copy Markdown
Collaborator

Modern setups (e.g., ubuntu 24.04) weren't able to build Pyfhel successfully anymore because of a few issues

  • the SEAL version we used had a dependency asking for cmake <3.5 compatibility which modern cmake no longer supports -> updated to most recent SEAL version
  • Python3.12 deprecated a few things and we had numpy/setuptools dependencies that were still using them -> bump numpy/setuptools version
  • There was also a minor bug in PyPoly.pyx - no idea why that hadn't popped up earlier, as it shouldn't have worked even on older setups...

This should fix #257, #256

Modern versions of cmake commonly installed on, e.g., recent Ubuntu releases, no longer support the old version of cmake required by some of the previous SEAL version's dependencies. By updating to the most recent SEAL version, we resolve this (and get some other bugfixes and improvements)
@codecov-commenter

codecov-commenter commented Jun 25, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.80%. Comparing base (e8788d1) to head (324c726).
⚠️ Report is 10 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files           3        3           
  Lines        1004     1005    +1     
=======================================
+ Hits          992      993    +1     
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlexanderViand
AlexanderViand force-pushed the dev branch 2 times, most recently from ead0ec3 to 324c726 Compare June 26, 2025 03:20
@AlexanderViand

Copy link
Copy Markdown
Collaborator Author

I can't get the macOS CI to work and since I don't have a macOS device on hand, I'm going to have to give up on that for the moment. Maybe @ibarrond or someone else with a macOS device can let me know if pip install . works locally (i.e., if it's purely a CI issue, or if the build is actually broken on macOS)

@ibarrond

Copy link
Copy Markdown
Owner

Merging these changes and pushing a new version to PyPI. The MacOS build will remain broken for now (although #263 might solve it)

@ibarrond
ibarrond merged commit 1d53f7e into master Aug 20, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Installation Anything happening during building/installation of Pyfhel

Projects

None yet

3 participants