Conversation
Modern versions of cmake commonly installed on, e.g., recent Ubuntu releases, no longer support the old version of cmake required by some of the previous SEAL version's dependencies. By updating to the most recent SEAL version, we resolve this (and get some other bugfixes and improvements)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 3 3
Lines 1004 1005 +1
=======================================
+ Hits 992 993 +1
Misses 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3ba932d to
34559be
Compare
9fbe038 to
df482e7
Compare
ead0ec3 to
324c726
Compare
|
I can't get the macOS CI to work and since I don't have a macOS device on hand, I'm going to have to give up on that for the moment. Maybe @ibarrond or someone else with a macOS device can let me know if |
|
Merging these changes and pushing a new version to PyPI. The MacOS build will remain broken for now (although #263 might solve it) |
Modern setups (e.g., ubuntu 24.04) weren't able to build Pyfhel successfully anymore because of a few issues
This should fix #257, #256