Skip to content

Commit f13c44e

Browse files
committed
Always use an angular cutoff of pi when fitting in the likelihood class.
1 parent 4f2a8aa commit f13c44e

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

kingmaker/wrapper.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,10 @@ def __init__(
8787

8888
# Obtain the King distribution parameters for all bins. If we're caching parameters
8989
# and a cache file exists, load from the cache instead of fitting. Otherwise,
90-
# run the fitter and potentially cache the results.
90+
# run the fitter and potentially cache the results. Note that if we run the fitter,
91+
# we explicitly set the angular cutoff to pi: this is to ensure that we allow the
92+
# full histogram to be fit for each bin without artificially setting the PDF to 0
93+
# for some bins.
9194
fitted_parameters: Dict[str, npt.NDArray[np.floating]] = {}
9295
if cache_parameters and (cache_name is not None) and exists(cache_name):
9396
fitted_parameters_npz = np.load(cache_name, allow_pickle=True)
@@ -100,7 +103,7 @@ def __init__(
100103
dpsi_nbins=dpsi_nbins,
101104
minimum_counts=minimum_counts,
102105
spectral_indices=spectral_indices,
103-
angular_cutoff=angular_cutoff,
106+
angular_cutoff=np.pi,
104107
weight_field=weight_field,
105108
true_ra_name=true_ra_name,
106109
true_dec_name=true_dec_name,

0 commit comments

Comments
 (0)