Repository navigation
fix(ui): prevent background sync from stealing focus when modal overlays are active - #215
Merged
Merged
Conversation
…ays are active - Unify modal overlay visibility tracking into hasActiveModal - Inhibit search field focus restoration during authStatusProc, vaultSyncProc, and vaultListProc callbacks while any modal is active - Guard global Shortcuts and imperative Keys.onPressed handlers with hasActiveModal to prevent background shortcut leakage during modal editing - Ensure restoreSearchFocus on modal close only executes when no other modal remains active - Add regression test in tests/tst_modal_focus.qml Fixes #212
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #212
Summary of Changes
hasActiveModalproperty combining visibility ofshowActionPalette,showSshKeyModal, andshowPasswordHistoryModal.authStatusProc,vaultSyncProc,vaultListProc) so that focus restoration to the search field is inhibited while any modal is active.Keys.onPressedandShortcuthandlers withhasActiveModalto prevent shortcut leakage during modal text editing.tests/tst_modal_focus.qmlwith 100% test coverage.Verification
qml6 tests/tst_modal_focus.qml: ALL PASSEDqml6 tests/tst_card_formatting.qml: ALL PASSEDqml6 tests/tst_lock_cleanup.qml: ALL PASSED