Remove unusable Casino building identifier - #276
Merged
Conversation
Owner
|
@Diffuin It may be better for us to make it obsolete/deprecated to avoid breaking old mods |
Author
|
I updated this pull request with commit |
ifBars
approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by @ifBars in #270.
Diffuin response
Confidence: High
Removed the unusable
S1API.Map.Buildings.Casinoidentifier and its catalog entry. This deliberately breaks source and binary compatibility for mods that referenceBuildings.Casino, as authorized, and fully resolves issue #270 without adding an unverified replacement abstraction.Recommended next steps
Evidence and validation
Evidence inspected
Buildingregisters and falls back only toNPCEnterableBuildinginstances for both target configurations.NPCEvent_StayInBuilding.BuildingandDealer.HomeasNPCEnterableBuilding.Casinoentry inS1API/Map/Buildings/Buildings.mdwere the only typed-building catalog references removed.Validation performed
git diff --check.Casinobuilding references underS1APIorS1API.Tests.Runtime validation remaining
dotnetis unavailable in this checkout environment.Diffuin run details
codexgpt-5.6-terrahigh(Luna advisor: balanced (high); baseline bounded implementation)01a002e2-9500-7273-add2-0ac49069f28aAI notice: Generated with AI assistance and not guaranteed accurate. Verify findings and plans against the current source and runtime.
Closes #270
Diffuin job:
69623915-65be-49cf-a513-d9b330ebb0efCommit:
3f7884bf33fa2dd2d09f2ead82ef6668c5f17fa3