Improved UI in the Scenario Selection dialogue screen

[AchFilip]

• Added Okay & Cancel buttons w/ left and right click triggers
• Hiding the Okay button that exists in the image.

Below you can see a video proof.

601745586-01ab52db-e6e8-460b-b525-4095973eb575.mp4

Related issue #10787

[Branikolog]

Hi, @AchFilip !
I haven't tested the build itself since it hasn't been compiled yet. However, from what I could see in the video, both new buttons appear to be missing their shadows. If this is still relevant, could you please add them as well?

[AchFilip]

Hi, @AchFilip ! I haven't tested the build itself since it hasn't been compiled yet. However, from what I could see in the video, both new buttons appear to be missing their shadows. If this is still relevant, could you please add them as well?

Hey @Branikolog,

Yeah I'll fix the code styling first and then I'll check the shadow thingy.
Missed that completely, my bad!

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

[ihhub]

Hi @AchFilip ,

This particular window should be completely reworked as we want it to be vertically resizable and be wider due to very little space left for map names. I know that this is a huge work to be done but we could fix many issues by doing this.

If you keen to give it a try I recommend to take a look at #10573 how other windows were done and also at dialog_resolution.cpp file (more specifically applyTextBackgroundShading() method which is helpful to replicate the needed shapes).

I understand that this is a very tedious task but it would also be very rewarding for players as this dialog is used not only for selection of maps in the Main Menu but also in the Editor. Moreover, me and @Districh-ru can help you with this if needed.

What do you think?

[AchFilip]

Hi @AchFilip ,

This particular window should be completely reworked as we want it to be vertically resizable and be wider due to very little space left for map names. I know that this is a huge work to be done but we could fix many issues by doing this.

If you keen to give it a try I recommend to take a look at #10573 how other windows were done and also at dialog_resolution.cpp file (more specifically applyTextBackgroundShading() method which is helpful to replicate the needed shapes).

I understand that this is a very tedious task but it would also be very rewarding for players as this dialog is used not only for selection of maps in the Main Menu but also in the Editor. Moreover, me and @Districh-ru can help you with this if needed.

What do you think?

Hey @ihhub !

I totally agree.
One more issue the current implementation has is it does not change theme between evil/good.
Yeah for sure! I'm totally hooked-up with this project.

[ihhub]

Hi @AchFilip ,
This particular window should be completely reworked as we want it to be vertically resizable and be wider due to very little space left for map names. I know that this is a huge work to be done but we could fix many issues by doing this.
If you keen to give it a try I recommend to take a look at #10573 how other windows were done and also at dialog_resolution.cpp file (more specifically applyTextBackgroundShading() method which is helpful to replicate the needed shapes).
I understand that this is a very tedious task but it would also be very rewarding for players as this dialog is used not only for selection of maps in the Main Menu but also in the Editor. Moreover, me and @Districh-ru can help you with this if needed.
What do you think?

Hey @ihhub !

I totally agree. One more issue the current implementation has is it does not change theme between evil/good. Yeah for sure! I'm totally hooked-up with this project.

Thank you! Please feel free to ask aby questions.