Conversation
Thorgal93
changed the title
|
Hi @Thorgal93 , I highly doubt that anyone would have time to review 1300+ lines of text just because you had no Internet access. The guideline is made to streamline the review process for reviewers. A human being isn't capable of reviewing hundreds and hundreds lines of text in one shot. |
|
Yeah, I'm well aware. As I said, I made the file available to french user in the discord for them to review. The engine wasn't really playable in french, now it is. |
|
|
||
| msgid "ABOUT" | ||
| msgstr "" | ||
| msgstr "A PROPOS" |
There was a problem hiding this comment.
| msgstr "A PROPOS" | |
| msgstr "À PROPOS" |
| "RE-\n" | ||
| "COMMENCER" |
There was a problem hiding this comment.
Ici on passe à la ligne entre "RE-" et "COMMENCER", ce qui peut être étrange à la lecture.
Proposition pour correspondre à l'approche anglaise "RESTART GAME" :
| "RE-\n" | |
| "COMMENCER" | |
| "RECOMMENCER-\n" | |
| "LA PARTIE" |
| @@ -254,7 +256,7 @@ msgid "" | |||
| msgstr "BATAILLE" | |||
|
|
|||
| msgid "SETTINGS" | |||
| msgstr "" | |||
| msgstr "PARAMETRES" | |||
There was a problem hiding this comment.
| msgstr "PARAMETRES" | |
| msgstr "PARAMÈTRES" |
|
|
||
| msgid "army|Pack" | ||
| msgstr "10-19" | ||
| msgstr "Un paquet" |
There was a problem hiding this comment.
Concernant les noms représentants le nombre d'unités dans une armée.
Idéalement on veut correspondre aux termes du jeu vanilla:
Quelques = 1-4
Plusieurs = 5-9
Groupe = 10-19
Beaucoup = 20-49
Horde = 50-99
Foule = 100-249
Nuée = 250-499
Multitude = 500-999
Légion = + 1000
Ces termes sont en un mot à chaque fois.
| msgstr "Un paquet" | |
| msgstr "Groupe" |
|
|
||
| msgid "army|Horde" | ||
| msgstr "50-99" | ||
| msgstr "Une horde" |
There was a problem hiding this comment.
| msgstr "Une horde" | |
| msgstr "Horde" |
| "Removes all negative spells cast upon one of your units, and restores up to %" | ||
| "{count} HP per level of spell power." |
There was a problem hiding this comment.
Ici même remarque que plus haut, en passant à la ligne on risque de casser la syntaxe des variables.
| "Removes all negative spells cast upon one of your units, and restores up to %" | |
| "{count} HP per level of spell power." | |
| "Removes all negative spells cast upon one of your units, and restores up to " | |
| "%{count} HP per level of spell power." |
| "Removes all negative spells cast upon your forces, and restores up to %" | ||
| "{count} HP per level of spell power, per creature." |
There was a problem hiding this comment.
Ici même remarque que plus haut, en passant à la ligne on risque de casser la syntaxe des variables.
| "Removes all negative spells cast upon your forces, and restores up to %" | |
| "{count} HP per level of spell power, per creature." | |
| "Removes all negative spells cast upon your forces, and restores up to " | |
| "%{count} HP per level of spell power, per creature." |
| "Supprime tous les sorts négatifs lancés sur vos forces, et restaure jusqu'à %" | ||
| "{count} de PV par niveau de Puissance, par créature." |
There was a problem hiding this comment.
Ici même remarque que plus haut, en passant à la ligne on risque de casser la syntaxe des variables.
| "Supprime tous les sorts négatifs lancés sur vos forces, et restaure jusqu'à %" | |
| "{count} de PV par niveau de Puissance, par créature." | |
| "Supprime tous les sorts négatifs lancés sur vos forces, et restaure jusqu'à " | |
| "%{count} de PV par niveau de Puissance, par créature." |
| "Brings a single enemy unit under your control if its hits are less than %" | ||
| "{count} times the caster's spell power." |
There was a problem hiding this comment.
Ici même remarque que plus haut, en passant à la ligne on risque de casser la syntaxe des variables.
| "Brings a single enemy unit under your control if its hits are less than %" | |
| "{count} times the caster's spell power." | |
| "Brings a single enemy unit under your control if its hits are less than " | |
| "%{count} times the caster's spell power." |
| "Ramène le lanceur du sort de retourner au dernier château récemment acquis. " | ||
| "Ce sort ne peut pas être lancé si le héros et déjà en ville ou dans un " | ||
| "château." |
There was a problem hiding this comment.
Ici le fait que le château ait été acquis récemment n'est pas en cause, il s'agit de téléporter le héros dans son château/village le plus proche.
| "Ramène le lanceur du sort de retourner au dernier château récemment acquis. " | |
| "Ce sort ne peut pas être lancé si le héros et déjà en ville ou dans un " | |
| "château." | |
| "Téléporte le lanceur du sort au château ou au village possédé le plus proche. " | |
| "Ce sort ne peut pas être lancé si le héros et déjà dans un village ou dans un " | |
| "château." |
zenseii
added
improvement
|
Hi @Thorgal93 , can you please address given comments? |
4 participants
Hello
This PR should bring the french language coverage to 100%.
I know i didn't respect the guideline for translators concerning the amount of lines modified but I have an excuse : i didn't have internet at the time of translation. I just downloaded the PO file on public wifi and started doing work.
My internet connection is up now which is why i make this PR.
I posted the changes in the discord for french users, and I'm awaiting their inputs.
Strangely, some lines in the PO files aren't taken into account by the game:
I had to compile from source to get the autoplay test feature to work and appear (& test).
I hope my +- 1,325 changes translation-dumping PR will be accepted :)
I didn't use any generative AI for this work.