Skip to content

Consider next unit on planning retreat - #10954

Open
tau3 wants to merge 7 commits into
ihhub:masterfrom
tau3:feature/10480/consider-next-unit
Open

tau3 wants to merge 7 commits into
ihhub:masterfrom
tau3:feature/10480/consider-next-unit

Conversation

@tau3

@tau3 tau3 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Hello!

This is an attempt to implement #10480

If some other checks besides army and morale of the next unit are required, I'll add them

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

Comment thread src/fheroes2/battle/battle_arena.h Outdated
Comment thread src/fheroes2/ai/ai_battle.cpp Outdated
Comment thread src/fheroes2/ai/ai_battle.cpp Outdated
Comment thread src/fheroes2/ai/ai_battle.cpp Outdated
@ihhub
ihhub marked this pull request as draft August 22, 2026 09:13
@tau3

tau3 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

@ihhub, could you help me with CI, please? I can see only code style checking error, but there is no context: file, line, etc.

@ihhub

ihhub commented Aug 31, 2026

Copy link
Copy Markdown
Owner

@ihhub, could you help me with CI, please? I can see only code style checking error, but there is no context: file, line, etc.

Click on ... next to failed CI stage to View Details.

@tau3

tau3 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

@ihhub, could you help me with CI, please? I can see only code style checking error, but there is no context: file, line, etc.

Click on ... next to failed CI stage to View Details.

Ah, thank you! I had some of JS disabled, so that page rendered as almost empty for me (so code snippets), now it's fine

@tau3
tau3 marked this pull request as ready for review September 14, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants