Skip to content

Commit 574ef54

Browse files
committed
fix: remove comments, fix version
1 parent b45c240 commit 574ef54

2 files changed

Lines changed: 1 addition & 22 deletions

File tree

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Package: immunarch
22
Type: Package
33
Title: Multi-Modal Immune Repertoire Analytics for Immunotherapy and Vaccine Design in R
4-
Version: 0.10.2
4+
Version: 0.10.3
55
Authors@R: c(
66
person("Vadim I.", "Nazarov", , "support@immunomind.com", role = c("aut", "cre"),
77
comment = c(ORCID = "0000-0003-3659-2709")),

R/v1_aaa_commons_vis.R

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,3 @@
1-
#
2-
# 1) Look at this for examples: https://chatgpt.com/c/68eacc4b-785c-832a-88f5-b94086ad7f26
3-
#
4-
# 2) Register in the registry. Registry should check if all visualisations are assigned to existing (!) classes.
5-
# vis_airr_diversity_chao1 <- ...
6-
# It is probably impossible to do...
7-
# Should use https://stat.ethz.ch/R-manual/R-devel/RHOME/library/base/html/S3method.html
8-
#
9-
# 3) I need registry to control the class system in one place. One for assigning classes following a specific schema, the other one is for parsing classes.
10-
# I probably need to write a short manual on the logic of this. And on the structure of the code. And on the phiolosophy / architectural design decisions. Same for immundata.
11-
#
12-
# 4) Key question: can I use different names? https://stackoverflow.com/questions/61482561/whats-the-preferred-means-for-defining-an-s3-method-in-an-r-package-without-int/61483612#61483612
13-
# https://vctrs.r-lib.org/reference/s3_register.html
14-
#
15-
# 5) [!!!] I still need some name for Roxygen to @inheritParams. There is no way around that.
16-
# opt.1 - dynamically register S3 stuff, one big vis() or some weird names for docs
17-
# opt.2 - pre-defined classes, vis() is constructed via @inheritParams
18-
# Or...
19-
# - https://github.com/r-lib/roxygen2/issues/1159
20-
# - https://github.com/rstudio/renv/blob/4a8bcb4605f085fbea5f29a76ad9a291ac2bd363/R/roxygen.R#L2-L26
21-
221
#' @keywords internal
232
make_fixed_col_plot <- function(x_col, y_col, title, xlab, ylab) {
243
checkmate::assert_string(x_col)

0 commit comments

Comments
 (0)