fix: 静的解析の副作用を防止 / Avoid analysis side effects

Author: inakaegg

CHANGELOG.md

@@ -10,6 +10,7 @@
 - Constant discovery now includes classes and modules assigned with `Class.new` / `Module.new` during the target file load.
 - Repeated loads retain assigned constant aliases when the source file is unchanged.
 - Repeated loads retain aliases from completed direct, multiple, and `const_set` assignments or matching fully qualified existence guards, including receivers found by Ruby's lexical constant fallback, without reviving failed assignments or aliases behind disabled conditions.
+- Constant discovery analyzes the preloaded source without triggering autoloads, so inactive autoload branches and self-removing target files do not add side effects or fail after a successful load.
 - Constructor arity errors raised by `--new` are now wrapped in Rubycli's user-facing runner error.
 - Framework argument errors raised by constructors are also wrapped in the same user-facing runner error.
 - Positional type conversion now waits for JSON/eval coercion, matching keyword-option behavior and preserving `--new` JSON/eval inputs.

lib/rubycli/argument_parser.rb

@@ -221,9 +221,10 @@ def valid_eval_option_value?(token, known_option_names)
     end
 
     def known_option_token?(token, known_option_names)
-      return false unless token&.match?(/\A-{1,2}[a-zA-Z0-9_-]+\z/)
+      match = token&.match(/\A-{1,2}([a-zA-Z0-9_-]+)(?:=.*)?\z/)
+      return false unless match
 
-      key = token.delete_prefix('--').delete_prefix('-').tr('-', '_')
+      key = match[1].tr('-', '_')
       return true if known_option_names.include?(key)
 
       known_option_names.one? { |name| name.start_with?(key) }

lib/rubycli/constant_capture.rb

@@ -12,6 +12,7 @@ def initialize
 
     def capture(file)
       normalized_file = normalize(file)
+      source = File.read(normalized_file)
       previous_names = @captured[normalized_file].dup
       previous_assignment_definitions = @assignment_definitions.fetch(normalized_file, {})
       executed_line_contexts = Hash.new { |hash, line| hash[line] = [] }
@@ -31,7 +32,7 @@ def capture(file)
     ensure
       trace&.disable
       if normalized_file && before_snapshot
-        current_assignment_definitions = assigned_constant_definitions(normalized_file)
+        current_assignment_definitions = assigned_constant_definitions(source)
         apply_trace_events(
           observed_events,
           executed_line_contexts,
@@ -209,8 +210,8 @@ def context_requirements_met?(active_context_events, required_context_events)
       end
     end
 
-    def assigned_constant_definitions(file)
-      syntax_tree = Ripper.sexp(File.read(file))
+    def assigned_constant_definitions(source)
+      syntax_tree = Ripper.sexp(source)
       return {} unless syntax_tree
 
       collect_assigned_constant_definitions(syntax_tree, [], [], {})
@@ -539,8 +540,10 @@ def resolve_lexical_constant_name(constant_name, namespace)
 
     def constant_path_defined?(name)
       parts = name.split('::')
-      parts.reduce(Object) do |owner, part|
+      parts.each_with_index.reduce(Object) do |owner, (part, index)|
         return false unless owner.is_a?(Module) && owner.const_defined?(part, false)
+        return true if index == parts.length - 1
+        return false if owner.autoload?(part, false)
 
         owner.const_get(part, false)
       end

test/argument_parser_test.rb

@@ -363,13 +363,17 @@ def test_eval_mode_accepts_option_looking_required_values
   def test_eval_mode_does_not_consume_known_option_as_required_value
     method = EvalRequiredOptionSamples.method(:run)
 
-    error = assert_raises(Rubycli::ArgumentError) do
-      Rubycli.with_eval_mode(true) do
+    Rubycli.with_eval_mode(true) do
+      plain_error = assert_raises(Rubycli::ArgumentError) do
         @parser.parse(['--callback', '--verbose'], method)
       end
-    end
+      embedded_error = assert_raises(Rubycli::ArgumentError) do
+        @parser.parse(['--callback', '--verbose=1'], method)
+      end
 
-    assert_includes error.message, "Option '--callback' requires a value"
+      assert_includes plain_error.message, "Option '--callback' requires a value"
+      assert_includes embedded_error.message, "Option '--callback' requires a value"
+    end
   end
 
   def test_validate_inputs_warns_when_values_outside_choices

test/constant_capture_test.rb

@@ -590,6 +590,59 @@ module CaptureFallbackConstSetNamespace
     end
   end
 
+  def test_does_not_trigger_autoload_while_resolving_const_set_receiver
+    capture = Rubycli::ConstantCapture.new
+    previous_marker = ENV['RUBYCLI_AUTOLOAD_CAPTURED']
+    Tempfile.create(['autoload_side_effect', '.rb']) do |autoload_file|
+      autoload_file.write(<<~RUBY)
+        ENV['RUBYCLI_AUTOLOAD_CAPTURED'] = 'yes'
+        module CaptureAutoloadConstSetOwner; end
+      RUBY
+      autoload_file.flush
+
+      Tempfile.create(['autoload_const_set_alias', '.rb']) do |target_file|
+        target_file.write(<<~RUBY)
+          autoload :CaptureAutoloadConstSetOwner, #{autoload_file.path.dump}
+          if false
+            CaptureAutoloadConstSetOwner.const_set(:Runner, Module.new)
+          end
+          module CaptureAutoloadActualRunner
+            def self.run; end
+          end
+        RUBY
+        target_file.flush
+
+        capture_io { capture.capture(target_file.path) { load target_file.path } }
+
+        assert_includes capture.constants_for(target_file.path), 'CaptureAutoloadActualRunner'
+        assert_nil ENV['RUBYCLI_AUTOLOAD_CAPTURED']
+      end
+    ensure
+      ENV['RUBYCLI_AUTOLOAD_CAPTURED'] = previous_marker
+      cleanup_constant(:CaptureAutoloadConstSetOwner)
+      cleanup_constant(:CaptureAutoloadActualRunner)
+    end
+  end
+
+  def test_uses_preloaded_source_when_target_deletes_itself
+    capture = Rubycli::ConstantCapture.new
+    Tempfile.create(['self_deleting_capture', '.rb']) do |file|
+      file.write(<<~RUBY)
+        module CaptureSelfDeletingRunner
+          def self.run; end
+        end
+        File.delete(__FILE__)
+      RUBY
+      file.flush
+
+      capture_io { capture.capture(file.path) { load file.path } }
+
+      assert_includes capture.constants_for(file.path), 'CaptureSelfDeletingRunner'
+    ensure
+      cleanup_constant(:CaptureSelfDeletingRunner)
+    end
+  end
+
   def test_does_not_match_existence_guard_for_another_namespace
     capture = Rubycli::ConstantCapture.new
     Tempfile.create(['qualified_guard_alias', '.rb']) do |file|