fix: Codexレビュー指摘を修正 / Fix Codex review findings

Author: inakaegg

.github/workflows/test.yml

@@ -52,4 +52,4 @@ jobs:
       - name: Enforce coverage thresholds
         run: ruby -Ilib:test test/coverage_runner.rb
         env:
-          COVERAGE_BASE_REF: origin/${{ github.base_ref || github.event.repository.default_branch }}
+          COVERAGE_BASE_REF: ${{ github.event_name == 'push' && github.event.created == false && github.event.deleted == false && github.event.before || format('origin/{0}', github.base_ref || github.event.repository.default_branch) }}

CHANGELOG.md

@@ -8,23 +8,29 @@
 - Required options accept negative exponent notation such as `-1e3` without mistaking it for another option.
 - Constant discovery now includes classes and modules assigned with `Class.new` / `Module.new` during the target file load.
 - Repeated loads retain assigned constant aliases when the source file is unchanged.
+- Repeated loads after source edits retain aliases created by direct, guarded, multiple, and `const_set` assignments while their active definitions remain, without reviving aliases behind newly disabled conditions.
 - Constructor arity errors raised by `--new` are now wrapped in Rubycli's user-facing runner error.
+- Framework argument errors raised by constructors are also wrapped in the same user-facing runner error.
 - Positional type conversion now waits for JSON/eval coercion, matching keyword-option behavior and preserving `--new` JSON/eval inputs.
 - Runner tests now execute without terminating the Minitest process and assert converted command arguments instead of stubbed targets.
 - `--check --new` now inspects exposed instance/class commands without running constructors, while `--check` rejects pre-scripts instead of evaluating them.
+- `--check` now inspects explicitly selected commands even when their methods or defining procs come from required files.
 - Explicit nested constant names no longer fall back to inherited top-level constants, and malformed pre-scripts now produce contextual Rubycli errors.
 - Rest, optional-before-required, and trailing-required positional arguments now follow Ruby's argument binding rules for conversion, validation, and help output.
 - Documented scalar/list conversions now preserve numeric-looking strings, handle repeated booleans, return real `DateTime` values, accept JSON arrays, and reject scalar/array values where `JSON`/`Hash` shapes do not allow them.
 - Positional `Symbol` annotations preserve colon-prefixed symbol literals instead of embedding the colon in the symbol name.
 - Assignment-like positional values remain positional unless they match a keyword, while matching assignments use the same documented conversion as long options.
 - YARD positional tags are aligned by parameter name instead of comment order.
 - Eval-mode local variables and command-line strict/check/result-output flags no longer leak across separate programmatic runs.
+- Constructor and command eval arguments share one binding per Runner execution without enabling eval mode while the target file loads.
+- Required options accept a lone `-` value, bare rest placeholders render with an ellipsis, and quoted `String[]` elements remain strings.
 - Invalid Ruby syntax passed through strict eval mode now produces a user-facing Rubycli argument error instead of leaking a `SyntaxError` backtrace.
 - Circular arrays/hashes returned by commands now fall back to inspected output instead of raising a JSON nesting error.
 
 ### Testing
 - Added dependency-free overall line, branch, and changed-line coverage gates plus GitHub Actions checks spanning the supported Ruby range.
 - Changed-line coverage now treats new library files that were never loaded by the test suite as uncovered.
+- Push coverage compares against the previous commit and falls back to the default branch when a new ref has no previous commit or a ref is deleted.
 
 ## [0.1.7] - 2025-11-12
 

README.ja.md

@@ -274,6 +274,8 @@ Rubycli が角括弧を補います。
 受け付けます。スペース区切りの複数値（`--tags build test`）には対応しておらず、
 繰り返し注記のないオプションはスカラーのままです。`--strict` 実行時は各要素の型も
 検証されるため、`[String[]]` と書かれた注釈に対して `--tags [1,2]` を渡すとエラーになります。
+`--tags '["true","null"]'` のように引用された要素は、別のリテラルに見える内容でも文字列の
+まま保持されます。
 
 ### リテラル列挙（enum）
 
@@ -417,8 +419,10 @@ rubycli -E scripts/report_runner.rb publish \
   --channels '[:email, :slack]'
 ```
 
-評価は隔離された binding（`Object.new.instance_eval { binding }`）内で行われますが、
-入力そのものは信頼できる呼び出し元に限定してください。プログラムからは
+評価は隔離された binding（`Object.new.instance_eval { binding }`）内で行われます。
+1回の Runner 実行では、`--new=VALUE` のコンストラクタ引数と選択したコマンドの引数を含む
+すべての eval 引数が同じ binding を共有し、実行終了時に破棄されます。入力そのものは
+信頼できる呼び出し元に限定してください。プログラムからは
 `Rubycli.with_eval_mode(true) { ... }` で切り替えられます。
 
 `--eval-lax` / `-E` は `--eval-args` と同様に eval モードを有効にしつつ、Ruby として

README.md

@@ -282,7 +282,9 @@ syntax (`--tags '["build","test"]'`) and comma-delimited strings
 (`--tags "build,test"`) are accepted. Space-separated multi-value flags
 (`--tags build test`) are not supported, and options without a repeated/array
 hint stay scalars. `--strict` verifies each element against the documented
-type, so `--tags [1,2]` fails when the docs say `[String[]]`.
+type, so `--tags [1,2]` fails when the docs say `[String[]]`. Quoted elements
+remain strings even when their contents look like other literals, such as
+`--tags '["true","null"]'`.
 
 ### Literal choices and enums
 
@@ -440,9 +442,11 @@ rubycli -E scripts/report_runner.rb publish \
 ```
 
 Evaluation happens inside an isolated binding
-(`Object.new.instance_eval { binding }`). Treat this as unsafe input: do not
-enable it for untrusted callers. Programmatic equivalent:
-`Rubycli.with_eval_mode(true) { ... }`.
+(`Object.new.instance_eval { binding }`). All eval arguments in one Runner
+execution, including `--new=VALUE` constructor arguments and the selected
+command's arguments, share that binding; it is discarded after the execution.
+Treat this as unsafe input: do not enable it for untrusted callers.
+Programmatic equivalent: `Rubycli.with_eval_mode(true) { ... }`.
 
 `--eval-lax` / `-E` behaves like `--eval-args`, but tokens that fail to parse
 as Ruby (for example a bare `https://example.com`) produce a warning and are

lib/rubycli.rb

@@ -221,24 +221,33 @@ def execute(
         raise Error, '--json-args cannot be combined with --eval-args or --eval-lax'
       end
 
-      runner_target, full_path = prepare_runner_target(
-        target_path,
-        class_name,
-        new: new,
-        new_args: new_args,
-        json_mode: json,
-        eval_mode: eval_args,
-        eval_lax: eval_lax,
-        pre_scripts: pre_scripts,
-        constant_mode: constant_mode
-      )
-
-      original_program_name = $PROGRAM_NAME
+      original_program_name = nil
       original_argv = nil
-      $PROGRAM_NAME = File.basename(full_path)
-      original_argv = ARGV.dup
-      ARGV.replace(Array(cli_args).dup)
-      run_with_modes(runner_target, json: json, eval_args: eval_args, eval_lax: eval_lax)
+      execution = proc do
+        runner_target, full_path = prepare_runner_target(
+          target_path,
+          class_name,
+          new: new,
+          new_args: new_args,
+          json_mode: json,
+          eval_mode: eval_args,
+          eval_lax: eval_lax,
+          pre_scripts: pre_scripts,
+          constant_mode: constant_mode
+        )
+
+        original_program_name = $PROGRAM_NAME
+        $PROGRAM_NAME = File.basename(full_path)
+        original_argv = ARGV.dup
+        ARGV.replace(Array(cli_args).dup)
+        run_with_modes(runner_target, json: json, eval_args: eval_args, eval_lax: eval_lax)
+      end
+
+      if eval_args
+        Rubycli.eval_coercer.with_eval_binding(&execution)
+      else
+        execution.call
+      end
     ensure
       $PROGRAM_NAME = original_program_name if original_program_name
       ARGV.replace(original_argv) if original_argv
@@ -372,7 +381,7 @@ def instantiate_target(target, initializer_args = nil)
       else
         target
       end
-    rescue ::ArgumentError => e
+    rescue ::ArgumentError, Rubycli::ArgumentError => e
       raise Error, "Failed to instantiate target: #{e.message}"
     end
 
@@ -382,7 +391,7 @@ def run_with_modes(target, json:, eval_args:, eval_lax:)
       if json
         Rubycli.with_json_mode(true, &runner)
       elsif eval_args
-        Rubycli.with_eval_mode(true, lax: eval_lax, &runner)
+        Rubycli.with_eval_mode(true, lax: eval_lax, reuse_binding: true, &runner)
       else
         runner.call
       end
@@ -399,7 +408,7 @@ def parse_initializer_arguments(raw_value, target, json_mode:, eval_mode:, eval_
       keyword_args = {}
 
       Rubycli.argument_mode_controller.with_json_mode(json_mode) do
-        Rubycli.argument_mode_controller.with_eval_mode(eval_mode, lax: eval_lax) do
+        Rubycli.argument_mode_controller.with_eval_mode(eval_mode, lax: eval_lax, reuse_binding: true) do
           positional_args, keyword_args = Rubycli.argument_parser.parse(tokens.dup, initializer_method)
           Rubycli.apply_argument_coercions(positional_args, keyword_args)
           Rubycli.argument_parser.validate_inputs(initializer_method, positional_args, keyword_args)
@@ -480,13 +489,12 @@ def documentation_methods_for(target, full_path, instantiate:)
         return methods
       end
 
-      normalized = normalize_path(full_path)
-      class_methods = collect_defined_methods(target.singleton_class, normalized)
+      class_methods = target.singleton_class.public_instance_methods(false)
                       .map { |name| target.method(name) }
                       .select { |method_obj| Rubycli.cli.send(:exposable_method?, method_obj) }
       return class_methods unless instantiate
 
-      instance_methods = collect_defined_methods(target, normalized)
+      instance_methods = target.public_instance_methods(false)
                          .map { |name| target.instance_method(name) }
                          .select { |method_obj| Rubycli.cli.send(:exposable_method?, method_obj) }
       target.is_a?(Class) ? instance_methods + class_methods : instance_methods

lib/rubycli/argument_parser.rb

@@ -743,13 +743,17 @@ def converter_for_single_type(type)
           inner = normalized[6..-2].strip
           element_converter = converter_for_single_type(inner)
           ->(value) {
-            list_items(value).map { |item| element_converter ? element_converter.call(item) : item }
+            list_items(value).map do |item|
+              inner == 'String' && item.is_a?(String) ? item : (element_converter ? element_converter.call(item) : item)
+            end
           }
         elsif normalized.end_with?('[]')
           inner = normalized[0..-3]
           element_converter = converter_for_single_type(inner)
           ->(value) {
-            list_items(value).map { |item| element_converter ? element_converter.call(item) : item }
+            list_items(value).map do |item|
+              inner == 'String' && item.is_a?(String) ? item : (element_converter ? element_converter.call(item) : item)
+            end
           }
         elsif normalized == 'Array'
           ->(value) { list_items(value) }
@@ -782,7 +786,7 @@ def convert_option_value(keyword, value, option_meta, type_converters)
 
     def looks_like_option?(token)
       return false unless token
-      return false if token == '--'
+      return false if token == '--' || token == '-'
 
       token.start_with?('-') && !token.match?(
         /\A-(?:\d+(?:\.\d*)?|\.\d+)(?:[eE][+-]?\d+)?\z/