Skip to content

IWF-1150: adding more logging for deleting S3 objects - #597

Merged
ktrops merged 1 commit into
mainfrom
jira/katiea/IWF-1150
Jan 7, 2026
Merged

IWF-1150: adding more logging for deleting S3 objects#597
ktrops merged 1 commit into
mainfrom
jira/katiea/IWF-1150

Conversation

@ktrops

@ktrops ktrops commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

Description

Checklist

  • Code compiles correctly
  • Tests for the changes have been added
  • All tests passing
  • This PR change is backwards-compatible
  • This PR CONTAINS a (planned) breaking change (it is not backwards compatible)

Related Issue

Closes #issue_number

@ktrops
ktrops force-pushed the jira/katiea/IWF-1150 branch from 54d9ec9 to 50a2568 Compare January 6, 2026 23:36
@codecov

codecov Bot commented Jan 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 18.75000% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.79%. Comparing base (b66886f) to head (50a2568).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
service/common/blobstore/store_impl.go 18.75% 26 Missing ⚠️

❌ Your patch status has failed because the patch coverage (18.75%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   65.84%   65.79%   -0.06%     
==========================================
  Files          64       64              
  Lines        6433     6464      +31     
==========================================
+ Hits         4236     4253      +17     
- Misses       1872     1886      +14     
  Partials      325      325              
Files with missing lines Coverage Δ
service/common/blobstore/store_impl.go 68.30% <18.75%> (-9.99%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ktrops
ktrops merged commit b357107 into main Jan 7, 2026
9 of 11 checks passed
@ktrops
ktrops deleted the jira/katiea/IWF-1150 branch January 7, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant