chore: fix 'non-constant format string' errors

Author: karel-rehor

influx/databases.go

@@ -126,7 +126,7 @@ func (c *Client) UpdateRP(ctx context.Context, db string, rp string, upd *chrono
 	// At last, we can check if there are any error strings
 	for _, r := range results {
 		if r.Error != "" {
-			return nil, fmt.Errorf(r.Error)
+			return nil, fmt.Errorf("%s", r.Error)
 		}
 	}
 

influx/influx.go

@@ -327,7 +327,7 @@ func (c *Client) ping(u *url.URL) (string, string, error) {
 	}
 
 	if resp.StatusCode != http.StatusNoContent {
-		var err = fmt.Errorf(string(body))
+		var err = fmt.Errorf("%s", string(body))
 		return "", "", err
 	}
 

influx/users.go

@@ -48,7 +48,7 @@ func (c *Client) Delete(ctx context.Context, u *chronograf.User) error {
 	// At last, we can check if there are any error strings
 	for _, r := range results {
 		if r.Error != "" {
-			return fmt.Errorf(r.Error)
+			return fmt.Errorf("%s", r.Error)
 		}
 	}
 	return nil
@@ -227,7 +227,7 @@ func (c *Client) updatePassword(ctx context.Context, name, passwd string) error
 	// At last, we can check if there are any error strings
 	for _, r := range results {
 		if r.Error != "" {
-			return fmt.Errorf(r.Error)
+			return fmt.Errorf("%s", r.Error)
 		}
 	}
 	return nil

oauth2/generic.go

@@ -115,7 +115,7 @@ func (g *Generic) PrincipalID(provider *http.Client) (string, error) {
 		if ok := ofDomain(g.Domains, email); !ok {
 			msg := "Not a member of required domain"
 			g.Logger.Error(msg)
-			return "", fmt.Errorf(msg)
+			return "", fmt.Errorf("%s", msg)
 		}
 	}