fix: show missing retention policies - #6145
Merged
Merged
Conversation
jansimonb
marked this pull request as ready for review
August 11, 2025 10:59
bednar
requested changes
Aug 11, 2025
bednar
left a comment
Contributor
There was a problem hiding this comment.
The implementation looks good. Please add a few tests similar to:
chronograf/influx/permissions_test.go
Line 347 in c8fff05
Contributor
karel-rehor
approved these changes
Aug 12, 2025
karel-rehor
left a comment
Contributor
There was a problem hiding this comment.
Short manual test result is in comment in conversation. Looks correct to me. 🚴 🏁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix parsing result of
SHOW RETENTION POLICIES. Enterprise v1.12.1 newly returns 2 new columns in the result:futureWriteLimitpastWriteLimitThese 2 new columns were unknown to chronograf yet, so the result parsing had to be fixed.
Now the code supports 2 result formats:
[name, duration, shardGroupDuration, replicaN, default][name, duration, shardGroupDuration, replicaN, futureWriteLimit, pastWriteLimit, default]Additionally, error logging was added to make it easier to detect similar issues in the future.
etc/Dockerfile_buildhave been pushed to DockerHub, and the changes have been added to.circleci/config.yml