Skip to content

Commit 8ea77c0

Browse files
committed
fix: resolve code review findings for PR #30
- [P1] Add publishConfig.access=public so the scoped @influxdata/* package publishes publicly on first npm publish. - [P2] Skip cloud-serverless integration job for forked PRs — fork runs cannot access environment secrets and would otherwise fail on empty credentials.
1 parent 20554cb commit 8ea77c0

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,12 @@ jobs:
105105
test-integration-cloud-serverless:
106106
name: Integration tests (InfluxDB Cloud Serverless)
107107
runs-on: ubuntu-latest
108-
if: github.repository_owner == 'influxdata'
108+
# Skip on forked PRs — environment secrets (INFLUXDB_CLOUD_URL/TOKEN) are
109+
# not exposed to fork runs, which would fail on empty credentials.
110+
if: |
111+
github.repository_owner == 'influxdata' &&
112+
(github.event_name == 'push' ||
113+
github.event.pull_request.head.repo.full_name == github.repository)
109114
environment: cloud-serverless
110115
steps:
111116
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
"description": "Official InfluxDB MCP server for Model Context Protocol integration",
55
"license": "(Apache-2.0 OR MIT)",
66
"private": false,
7+
"publishConfig": {
8+
"access": "public"
9+
},
710
"type": "module",
811
"engines": {
912
"node": ">=20.11.0"

0 commit comments

Comments
 (0)