Skip to content

fix: forward query routing options - #90

Merged
jstirnaman merged 1 commit into
mainfrom
fix/query-routing-options
Jul 29, 2026
Merged

fix: forward query routing options#90
jstirnaman merged 1 commit into
mainfrom
fix/query-routing-options

Conversation

@jstirnaman

Copy link
Copy Markdown
Collaborator

What changed

Query routing options (params, timeoutMs) now propagate to the product-type-specific query executors instead of being silently dropped.

  • executeCloudDedicatedQuery and executeCloudServerlessQuery accept options and pass named params to the Flight client's queryPoints.
  • executeClusteredQuery accepts options and forwards params/timeout to the HTTP request.
  • Added flightParams() to validate Flight-unsupported inputs: rejects timeoutMs (Flight has no per-query timeout), rejects array-style params (Flight requires named params), and rejects non-primitive param values.
  • InfluxQL query path (executeClusteredQuery callsite) also now forwards options.

Why

The public query methods accepted options but the private per-product executors ignored it, so callers passing query params or a timeout got no error and no effect — the option was silently discarded.

Impact

  • Core/Enterprise callers: unaffected (already forwarded options).
  • Cloud Dedicated / Cloud Serverless (Flight): params now actually apply to queries; timeoutMs and array params now throw instead of being ignored.
  • Clustered: params/timeoutMs now forwarded to the HTTP query request.

Verification

  • npm run build — clean
  • npm test — 91 passed, 28 skipped
  • Added tests/query-routing.test.ts covering options forwarding and the new Flight validation errors

@jstirnaman
jstirnaman temporarily deployed to cloud-serverless July 29, 2026 23:07 — with GitHub Actions Inactive
@jstirnaman
jstirnaman merged commit 00fdb73 into main Jul 29, 2026
5 checks passed
@jstirnaman
jstirnaman deleted the fix/query-routing-options branch July 29, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant