fix: forward query routing options - #90
Merged
Merged
Conversation
jstirnaman
temporarily deployed
to
cloud-serverless
July 29, 2026 23:07 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Query routing options (
params,timeoutMs) now propagate to the product-type-specific query executors instead of being silently dropped.executeCloudDedicatedQueryandexecuteCloudServerlessQueryacceptoptionsand pass namedparamsto the Flight client'squeryPoints.executeClusteredQueryacceptsoptionsand forwardsparams/timeoutto the HTTP request.flightParams()to validate Flight-unsupported inputs: rejectstimeoutMs(Flight has no per-query timeout), rejects array-style params (Flight requires named params), and rejects non-primitive param values.executeClusteredQuerycallsite) also now forwardsoptions.Why
The public query methods accepted
optionsbut the private per-product executors ignored it, so callers passing query params or a timeout got no error and no effect — the option was silently discarded.Impact
paramsnow actually apply to queries;timeoutMsand array params now throw instead of being ignored.params/timeoutMsnow forwarded to the HTTP query request.Verification
npm run build— cleannpm test— 91 passed, 28 skippedtests/query-routing.test.tscovering options forwarding and the new Flight validation errors