Feature/lab1 Tikhon Makeev - #1537
Open
tikhonmakeev wants to merge 4 commits into
Open
Conversation
Signed-off-by: tikhonmakeev <t.makeev@edu.centraluniversity.ru>
Signed-off-by: tikhonmakeev <t.makeev@edu.centraluniversity.ru>
There was a problem hiding this comment.
🟡 Changes recommended
The submission is incomplete and contains invalid or inaccurate documentation that must be corrected.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This pull request documents Lab 1 verification for QuickNotes and signed commits.
Changes:
- Adds endpoint output for health and notes requests.
- Records signed commit verification.
- Adds signing rationale and badge screenshot.
File summaries
| File | Description |
|---|---|
submissions/lab1.md |
Lab 1 evidence and explanation |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -0,0 +1,98 @@ | |||
| # Lab 1 submission | |||
| "body": "GET /notes GET /notes/{id} POST /notes DELETE /notes/{id} GET /health GET /metrics", | ||
| "created_at": "2026-01-15T10:15:00Z" | ||
| } | ||
|
|
Comment on lines
+94
to
+95
| ## Screenshoted verified bage | ||
|  |
|  | ||
|
|
||
| ## Why it matters | ||
| As I remember, story was something like "project merged bad commits with backdoor because trusted famous collaborator in community". So signed commits saves us from issue we have in git -- everybody can chose his username and email of commit, git never checks it. We need to check authority -- so we sign every commit (on public repos must have) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Changes
Testing
Checklist
git log --show-signature)submissions/labN.mdupdated