Repository navigation
[3299 by Claude Opus 5.5] Fix Ultrafix Settings documentation link to the existing command guide - #3300
Conversation
![propr-dev[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…checks the link as it actually renders. The link now goes to `https://docs.propr.dev/docs/features/pr-commands#ultrafix` (`UltrafixSettingsSection.tsx:44`), the same place the Settings category guide already points. Regression coverage - I moved the docs-route check out of `settingsCategoryGuides.test.ts` into a shared helper, `expectExistingDocsRoute()`, in `docsRoutes.testUtils.ts`. It checks that the page exists under `docs/docs/` and that the anchor matches a heading on that page. The category guide tests now call this helper. - A new test in `WorkflowSettingsSection.test.tsx` renders `UltrafixSettingsSection`, takes the `href` from the "Ultrafix docs" link and checks it with the helper. It reads the URL from the screen rather than repeating a hardcoded one. - A second new test confirms the helper throws for the old `pr-ultrafix-commands` route and for a missing heading. - To prove the test catches the original bug, I briefly put the old href back. The new test failed with `docs/docs/features/pr-ultrafix-commands.md is missing`; I then restored the fix. What I ran (all passed first time, no retries, skips or timeout changes) - `npx vitest run src/pages/SettingsPage`: 25 files, 218 tests passed. That includes 7 in `WorkflowSettingsSection.test.tsx` and the category-guide suite. - `npm run typecheck` (`tsc --noEmit`): clean. - `npx eslint --max-warnings 0 src/pages/SettingsPage`: clean. - I didn't run the full UI test suite or the Playwright tests. Live site: the new docs page returns 200 and its HTML has the `id=ultrafix` heading. The old URL still returns 404. Nothing else changed: no Settings text, layout or behavior, no other links, no docs edits and no redirect. The only visible difference is where the link goes, so I didn't make preview images.
|
/review gpt-6-astra |
|
✅ AI Code Review Complete requested by @integry Posted 1 review: |
🔍 AI Code Review — gpt-6-astraOverall EvaluationReady to merge within the visible scope, conditional on pending checks completing successfully. ✅ Correct destination — ✅ Rendered-link coverage — The new component test validates the rendered link against the documentation tree. Extracting the existing validator preserves category-guide coverage, and negative tests check rejection of missing pages and headings. This was a static review of the complete supplied diff and context; no commands were run. The issue description is truncated, so requirements beyond its visible text could not be assessed. Current checks show no failures and six pending. Merge blockersNo merge blockers. SuggestionsThese are optional follow-ups and are not sent to S1: 🟢 Assert the intended destinationIn ScoreThe focused fix satisfies the visible objective and adds relevant regression coverage without an identified regression. Pending checks remain the final validation step. Score: 9/10 🤖 Review Details
Copy and edit to choose records from this review: 🤖 Review by ProPR |
AI Implementation Summary
Closes #3299
Branch:
3299/claude-opus-5-5-fix-ultrafix-settings-doc-20261020-1832-sndCommits: ✅ Changes committed (f826fd3)
AI Processing Completed
Execution Details:
Summary:
I've fixed the Ultrafix docs link in Settings, and added a test that checks the link as it actually renders. The link now goes to
https://docs.propr.dev/docs/features/pr-commands#ultrafix(UltrafixSettingsSection.tsx:44), the same place the Settings category guide already points.Regression coverage
settingsCategoryGuides.test.tsinto a shared helper,expectExistingDocsRoute(), indocsRoutes.testUtils.ts. It checks that the page exists underdocs/docs/and that the anchor matches a heading on that page. The category guide tests now call this helper.WorkflowSettingsSection.test.tsxrendersUltrafixSettingsSection, takes thehreffrom the "Ultrafix docs" link and checks it with the helper. It reads the URL from the screen rather than repeating a hardcoded one.pr-ultrafix-commandsroute and for a missing heading.docs/docs/features/pr-ultrafix-commands.md is missing; I then restored the fix.What I ran (all passed first time, no retries, skips or timeout changes)
npx vitest run src/pages/SettingsPage: 25 files, 218 tests passed. That includes 7 inWorkflowSettingsSection.test.tsxand the category-guide suite.npm run typecheck(tsc --noEmit): clean.npx eslint --max-warnings 0 src/pages/SettingsPage: clean.Live site: the new docs page returns 200 and its HTML has the
id=ultrafixheading. The old URL still returns 404.Nothing else changed: no Settings text, layout or behavior, no other links, no docs edits and no redirect. The only visible difference is where the link goes, so I didn't make preview images.
Detailed Logs:
3dff0fda-a48e-43c2-bee7-0a0164de44ffLog files stored at:
/usr/src/app/logs/executions/issue-3299-2026-10-20T18-35-57-449Z-conversation.json/usr/src/app/logs/executions/issue-3299-2026-10-20T18-35-57-449Z-output.txtLatest Conversation Messages
This PR was created automatically by ProPR after processing issue #3299.
💡 Need changes?
Comment on this PR to request refinements — the AI agent monitors comments and will update the implementation based on your feedback. Keep iterating until you're satisfied!