Skip to content

Commit 7310751

Browse files
quinnlpclaude
andcommitted
[CI] Grant id-token to benchmark wheel-build jobs for Sigstore signing
PR #7840 added a keyless Sigstore signing step to the reusable build-benchmarks-wheel.yml, which requires `id-token: write`. The workflows that call it only granted `permissions: read-all`, which excludes id-token. A reusable workflow cannot request more token permissions than its caller, so every triggered benchmark workflow failed at startup validation ("workflow file issue", startup_failure) with zero jobs. Add a job-level `permissions` block granting `contents: read` and `id-token: write` on each build-wheel job that calls the reusable signing workflow, leaving `read-all` intact for all other jobs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 05348af commit 7310751

7 files changed

Lines changed: 21 additions & 0 deletions

.github/workflows/on-label.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,9 @@ jobs:
8484
contains(github.event.pull_request.labels.*.name, 'run-benchmarks') ||
8585
contains(github.event.pull_request.labels.*.name, 'run-vllm-benchmarks') ||
8686
contains(github.event.pull_request.labels.*.name, 'run-sglang-benchmarks')
87+
permissions:
88+
contents: read
89+
id-token: write # for Sigstore signing in the called workflow
8790
uses: ./.github/workflows/build-benchmarks-wheel.yml
8891
with:
8992
python-version: "3.12"

.github/workflows/sglang-benchmarks-bmg.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ concurrency:
2222

2323
jobs:
2424
build-wheel:
25+
permissions:
26+
contents: read
27+
id-token: write # for Sigstore signing in the called workflow
2528
uses: ./.github/workflows/build-benchmarks-wheel.yml
2629
with:
2730
python-version: "3.12"

.github/workflows/sglang-benchmarks-pvc.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ concurrency:
2222

2323
jobs:
2424
build-wheel:
25+
permissions:
26+
contents: read
27+
id-token: write # for Sigstore signing in the called workflow
2528
uses: ./.github/workflows/build-benchmarks-wheel.yml
2629
with:
2730
python-version: "3.12"

.github/workflows/triton-benchmarks-bmg.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ on:
1717

1818
jobs:
1919
build-wheel:
20+
permissions:
21+
contents: read
22+
id-token: write # for Sigstore signing in the called workflow
2023
uses: ./.github/workflows/build-benchmarks-wheel.yml
2124
with:
2225
python-version: "3.12"

.github/workflows/triton-benchmarks-pvc.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ on:
1717

1818
jobs:
1919
build-wheel:
20+
permissions:
21+
contents: read
22+
id-token: write # for Sigstore signing in the called workflow
2023
uses: ./.github/workflows/build-benchmarks-wheel.yml
2124
with:
2225
python-version: "3.12"

.github/workflows/vllm-benchmarks-bmg.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ concurrency:
2323

2424
jobs:
2525
build-wheel:
26+
permissions:
27+
contents: read
28+
id-token: write # for Sigstore signing in the called workflow
2629
uses: ./.github/workflows/build-benchmarks-wheel.yml
2730
with:
2831
python-version: "3.12"

.github/workflows/vllm-benchmarks-pvc.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ concurrency:
2323

2424
jobs:
2525
build-wheel:
26+
permissions:
27+
contents: read
28+
id-token: write # for Sigstore signing in the called workflow
2629
uses: ./.github/workflows/build-benchmarks-wheel.yml
2730
with:
2831
python-version: "3.12"

0 commit comments

Comments
 (0)