Skip to content

Commit 0de8027

Browse files
authored
Lint updates with Dart 3.13.0 (#696)
1 parent 0702713 commit 0de8027

89 files changed

Lines changed: 510 additions & 416 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

analysis_options.yaml

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ linter:
2424
- always_use_package_imports
2525
- annotate_overrides
2626
- annotate_redeclares
27+
- async_return_with_no_await
2728
# - avoid_annotating_with_dynamic
2829
- avoid_bool_literals_in_conditional_expressions
2930
- avoid_catches_without_on_clauses
@@ -85,18 +86,21 @@ linter:
8586
- directives_ordering
8687
- discarded_futures
8788
- do_not_use_environment
88-
# - document_ignores
89+
- document_ignores
8990
- empty_catches
9091
- empty_constructor_bodies
92+
- empty_container_bodies
9193
- empty_statements
9294
- eol_at_end_of_file
9395
- exhaustive_cases
9496
- file_names
9597
- flutter_style_todos
98+
# - future_sync_value - not valid yet, but should be enabled when it is
9699
- hash_and_equals
97100
- implementation_imports
98101
- implicit_call_tearoffs
99102
- implicit_reopen
103+
- initialize_in_field_declaration
100104
- invalid_case_patterns
101105
- invalid_runtime_check_with_js_interop_types
102106
- join_return_with_assignment
@@ -108,16 +112,19 @@ linter:
108112
- lines_longer_than_80_chars
109113
- literal_only_boolean_expressions
110114
- matching_super_parameters
115+
- migrate_design_widgets
111116
- missing_code_block_language_in_doc_comment
112117
- missing_whitespace_between_adjacent_strings
113118
- no_adjacent_strings_in_list
114119
- no_default_cases
115120
- no_duplicate_case_values
121+
- no_dynamic_casts
116122
- no_leading_underscores_for_library_prefixes
117123
- no_leading_underscores_for_local_identifiers
118124
- no_literal_bool_comparisons
119125
- no_logic_in_create_state
120-
- no_runtimeType_toString
126+
- no_raw_types
127+
- no_runtimetype_tostring
121128
- no_self_assignments
122129
- no_wildcard_variable_uses
123130
- non_constant_identifier_names
@@ -177,8 +184,11 @@ linter:
177184
- provide_deprecation_message
178185
- public_member_api_docs
179186
- recursive_getters
187+
- remove_deprecations_in_breaking_versions
180188
# - require_trailing_commas
181189
- secure_pubspec_urls
190+
- simple_directive_paths
191+
- simplify_variable_pattern
182192
- sized_box_for_whitespace
183193
- sized_box_shrink_expand
184194
- slash_for_doc_comments
@@ -190,7 +200,7 @@ linter:
190200
# - specify_nonobvious_local_variable_types
191201
# - specify_nonobvious_property_types
192202
- strict_top_level_inference
193-
# - switch_on_type
203+
- switch_on_type
194204
- test_types_in_equals
195205
- throw_in_finally
196206
- tighten_type_of_initializing_formals
@@ -199,11 +209,12 @@ linter:
199209
- type_literal_in_constant_pattern
200210
- unawaited_futures
201211
- unintended_html_in_doc_comment
202-
# - unnecessary_async
212+
- unnecessary_async
203213
- unnecessary_await_in_return
204214
- unnecessary_brace_in_string_interps
205215
- unnecessary_breaks
206216
- unnecessary_const
217+
- unnecessary_const_in_enum_constructor
207218
- unnecessary_constructor_name
208219
# - unnecessary_final
209220
- unnecessary_getters_setters
@@ -220,19 +231,23 @@ linter:
220231
- unnecessary_nullable_for_final_variable_declarations
221232
- unnecessary_overrides
222233
- unnecessary_parenthesis
234+
- unnecessary_primary_constructor_body
223235
- unnecessary_raw_strings
224236
# - unnecessary_statements
225237
- unnecessary_string_escapes
226238
- unnecessary_string_interpolations
227239
- unnecessary_this
240+
# - unnecessary_this_alias - not recognized yet, but should be enabled when it is
228241
- unnecessary_to_list_in_spreads
229-
# - unnecessary_unawaited
242+
- unnecessary_type_name_in_constructor
243+
- unnecessary_unawaited
230244
- unnecessary_underscores
231245
# - unreachable_from_main
232246
- unrelated_type_equality_checks
233-
# - unsafe_variance
247+
- unsafe_variance
234248
- use_build_context_synchronously
235249
- use_colored_box
250+
- use_declaring_parameters
236251
- use_decorated_box
237252
- use_enums
238253
- use_full_hex_values_for_flutter_colors
@@ -253,4 +268,5 @@ linter:
253268
- use_to_and_as_if_applicable
254269
- use_truncating_division
255270
- valid_regexps
271+
- var_with_no_type_annotation
256272
- void_checks

benchmark/ssa_driver_search_benchmark.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (C) 2023 Intel Corporation
1+
// Copyright (C) 2023-2026 Intel Corporation
22
// SPDX-License-Identifier: BSD-3-Clause
33
//
44
// ssa_driver_search_benchmark.dart
@@ -67,6 +67,6 @@ class SsaDriverSearchBenchmark extends BenchmarkBase {
6767
}
6868
}
6969

70-
void main() async {
70+
void main() {
7171
SsaDriverSearchBenchmark().report();
7272
}

doc/tutorials/chapter_1/01_setup_installation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ code .
9696
Delete all the content in `bin/rohd_project.dart` and replace with:
9797

9898
```dart
99-
// ignore_for_file: avoid_print
99+
// ignore_for_file: avoid_print - tutorial
100100
101101
// Import the ROHD package
102102
import 'package:rohd/rohd.dart';

doc/tutorials/chapter_2/a_logic.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (C) 2023 Intel Corporation
1+
// Copyright (C) 2023-2026 Intel Corporation
22
// SPDX-License-Identifier: BSD-3-Clause
33
//
44
// a_logic.dart
@@ -7,7 +7,7 @@
77
// 2023 February 20
88
// Author: Yao Jing Quek <yao.jing.quek@intel.com>
99

10-
// ignore_for_file: avoid_print
10+
// ignore_for_file: avoid_print - tutorial
1111

1212
import 'package:rohd/rohd.dart';
1313
import 'helper.dart';

doc/tutorials/chapter_2/answers/exercise_1.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (C) 2023-2025 Intel Corporation
1+
// Copyright (C) 2023-2026 Intel Corporation
22
// SPDX-License-Identifier: BSD-3-Clause
33
//
44
// exercise_1.dart
@@ -7,7 +7,7 @@
77
// 2023 February 14
88
// Author: Yao Jing Quek <yao.jing.quek@intel.com>
99

10-
// ignore_for_file: avoid_print
10+
// ignore_for_file: avoid_print - tutorial
1111

1212
import 'package:rohd/rohd.dart';
1313

doc/tutorials/chapter_2/answers/exercise_2.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (C) 2023-2025 Intel Corporation
1+
// Copyright (C) 2023-2026 Intel Corporation
22
// SPDX-License-Identifier: BSD-3-Clause
33
//
44
// exercise_2.dart
@@ -7,7 +7,7 @@
77
// 2023 February 14
88
// Author: Yao Jing Quek <yao.jing.quek@intel.com>
99

10-
// ignore_for_file: avoid_print
10+
// ignore_for_file: avoid_print - tutorial
1111
import 'package:rohd/rohd.dart';
1212
import '../helper.dart';
1313

doc/tutorials/chapter_2/answers/exercise_3.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (C) 2023 Intel Corporation
1+
// Copyright (C) 2023-2026 Intel Corporation
22
// SPDX-License-Identifier: BSD-3-Clause
33
//
44
// exercise_3.dart
@@ -7,7 +7,7 @@
77
// 2023 February 14
88
// Author: Yao Jing Quek <yao.jing.quek@intel.com>
99

10-
// ignore_for_file: avoid_print
10+
// ignore_for_file: avoid_print - tutorial
1111

1212
import 'package:rohd/rohd.dart';
1313

doc/tutorials/chapter_2/b_logic_width.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (C) 2023-2025 Intel Corporation
1+
// Copyright (C) 2023-2026 Intel Corporation
22
// SPDX-License-Identifier: BSD-3-Clause
33
//
44
// a_logic_width.dart
@@ -7,7 +7,7 @@
77
// 2023 February 20
88
// Author: Yao Jing Quek <yao.jing.quek@intel.com>
99

10-
// ignore_for_file: avoid_print
10+
// ignore_for_file: avoid_print - tutorial
1111

1212
import 'package:rohd/rohd.dart';
1313
import 'helper.dart';

doc/tutorials/chapter_2/d_assignment_operator.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (C) 2023-2025 Intel Corporation
1+
// Copyright (C) 2023-2026 Intel Corporation
22
// SPDX-License-Identifier: BSD-3-Clause
33
//
44
// d_assignment_operator.dart
@@ -7,7 +7,7 @@
77
// 2023 February 20
88
// Author: Yao Jing Quek <yao.jing.quek@intel.com>
99

10-
// ignore_for_file: avoid_print
10+
// ignore_for_file: avoid_print - tutorial
1111

1212
import 'package:rohd/rohd.dart';
1313
import 'helper.dart';

doc/tutorials/chapter_2/f_logic_gate_part_3.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (C) 2023-2025 Intel Corporation
1+
// Copyright (C) 2023-2026 Intel Corporation
22
// SPDX-License-Identifier: BSD-3-Clause
33
//
44
// f_logic_gate_part_3.dart
@@ -7,7 +7,7 @@
77
// 2023 February 20
88
// Author: Yao Jing Quek <yao.jing.quek@intel.com>
99

10-
// ignore_for_file: avoid_print
10+
// ignore_for_file: avoid_print - tutorial
1111

1212
import 'package:rohd/rohd.dart';
1313
import 'helper.dart';

0 commit comments

Comments
 (0)