Merge pull request #4 from intelliDean/rev

restructure the logging

Author: intelliDean

crates/api/src/handlers/add_bank.rs

@@ -7,7 +7,7 @@ use payego_core::services::bank_account_service::{
 };
 use payego_primitives::error::ApiErrorResponse;
 use std::sync::Arc;
-use tracing::error;
+use tracing::warn;
 use validator::Validate;
 
 #[utoipa::path(
@@ -34,7 +34,7 @@ pub async fn add_bank_account(
     Json(req): Json<BankRequest>,
 ) -> Result<(StatusCode, Json<BankAccountResponse>), ApiError> {
     req.validate().map_err(|e| {
-        error!("Validation error: {}", e);
+        warn!("add_bank: validation error");
         ApiError::Validation(e)
     })?;
 

crates/api/src/handlers/current_user.rs

@@ -11,12 +11,12 @@ use std::sync::Arc;
 #[utoipa::path(
     get,
     path = "/api/user/current",
+    tag = "User",
     summary = "Get current authenticated user details",
     description = "Retrieves profile information for the currently authenticated user based on the JWT bearer token. \
-                   Returns user data including ID, email, name, etc. \
+                   Returns user data including ID, email, name, phone, and account status. \
                    Requires a valid authentication token.",
     operation_id = "getCurrentUser",
-    tags = ["Authentication"],
     responses(
         (status = 200,description = "Successfully retrieved current user data",body = CurrentUserResponse,),
         (status = 401,description = "Unauthorized – missing, invalid, or expired token",body = ApiErrorResponse,),

crates/api/src/handlers/delete_bank.rs

@@ -18,10 +18,10 @@ use uuid::Uuid;
         ("bank_account_id" = Uuid, Path, description = "Bank account ID to delete")
     ),
     responses(
-        (status = 204, description = "Bank account deleted successfully"),
+        (status = 200, description = "Bank account deleted successfully", body = DeleteResponse),
         (status = 401, description = "Unauthorized – missing or invalid token", body = ApiErrorResponse),
-        (status = 404, description = "Bank account not found", body = ApiErrorResponse),
-        (status = 409, description = "Bank account cannot be deleted", body = ApiErrorResponse),
+        (status = 404, description = "Bank account not found or does not belong to user", body = ApiErrorResponse),
+        (status = 409, description = "Conflict – bank account cannot be deleted (e.g., pending transactions)", body = ApiErrorResponse),
         (status = 500, description = "Internal server error", body = ApiErrorResponse),
     ),
     security(("bearerAuth" = [])),

crates/api/src/handlers/get_transaction.rs

@@ -8,14 +8,14 @@ use std::sync::Arc;
 #[utoipa::path(
     get,
     path = "/api/user/transactions",
+    tag = "Transactions",
     summary = "Get list of user transactions",
     description = "Retrieves a paginated list of the authenticated user's transaction history. \
                    Includes deposits, withdrawals, internal transfers, external transfers, \
                    top-ups, payments, and other wallet activities. \
                    Results are ordered by creation date (newest first). \
                    Supports filtering and pagination via query parameters.",
     operation_id = "getUserTransactions",
-    tags = ["Transactions"],
 
     responses(
         (status = 200,description = "Successfully retrieved paginated list of transactions",body = TransactionsResponse),

crates/api/src/handlers/health.rs

@@ -3,7 +3,7 @@ use diesel::prelude::*;
 use payego_primitives::models::app_state::AppState;
 use payego_primitives::models::dtos::auth_dto::HealthStatus;
 use std::sync::Arc;
-use tracing::log::error;
+use tracing::error;
 
 #[utoipa::path(
     get,

crates/api/src/handlers/internal_conversion.rs

@@ -4,7 +4,7 @@ use payego_core::services::conversion_service::{
 };
 use payego_primitives::error::ApiErrorResponse;
 use std::sync::Arc;
-use tracing::error;
+use tracing::warn;
 use validator::Validate;
 
 #[utoipa::path(
@@ -35,7 +35,7 @@ pub async fn convert_currency(
     Json(req): Json<ConvertRequest>,
 ) -> Result<Json<ConvertResponse>, ApiError> {
     req.validate().map_err(|e| {
-        error!("Validation error: {}", e);
+        warn!("convert_currency: validation error");
         ApiError::Validation(e)
     })?;
 

crates/api/src/handlers/login.rs

@@ -10,7 +10,7 @@ use std::sync::Arc;
     path = "/api/auth/login",
     tag = "Authentication",
     summary = "Authenticate user and obtain JWT token",
-    description = "Authenticates a user using email and password\
+    description = "Authenticates a user using email and password. \
                    On success, returns a JWT access token, email and a refresh token that can be used \
                    for subsequent authenticated requests via the `Authorization: Bearer <token>` header. \
                    This is a public endpoint — no prior authentication is required.",

crates/api/src/handlers/refresh_token.rs

@@ -4,7 +4,7 @@ use payego_core::services::auth_service::token::{
 };
 use payego_primitives::error::ApiErrorResponse;
 use std::sync::Arc;
-use tracing::log::error;
+use tracing::warn;
 use validator::Validate;
 
 #[utoipa::path(
@@ -38,7 +38,7 @@ pub async fn refresh_token(
     Json(payload): Json<RefreshRequest>,
 ) -> Result<Json<RefreshResponse>, ApiError> {
     payload.validate().map_err(|e| {
-        error!("Validation error: {}", e);
+        warn!("refresh_token: validation error");
         ApiError::Validation(e)
     })?;
 

crates/api/src/handlers/register.rs

@@ -7,7 +7,7 @@ use payego_core::services::auth_service::register::{
 };
 use payego_primitives::error::ApiErrorResponse;
 use std::sync::Arc;
-use tracing::log::error;
+use tracing::warn;
 use validator::Validate;
 
 #[utoipa::path(
@@ -43,7 +43,7 @@ pub async fn register(
     let payload = payload.normalize();
 
     payload.validate().map_err(|e| {
-        error!("Validation error: {}", e);
+        warn!("register: validation error");
         ApiError::Validation(e)
     })?;
 

crates/api/src/handlers/resolve_account.rs

@@ -19,6 +19,10 @@ use tracing::info;
                    Requires valid Nigerian bank code (from Paystack supported banks list) and 10-digit account number. \
                    The endpoint is rate-limited and depends on Paystack availability — cache results when possible for repeated lookups.",
     operation_id = "resolveAccountName",
+    params(
+        ("account_number" = String, Query, description = "10-digit bank account number to verify"),
+        ("bank_code" = String, Query, description = "Bank code from Paystack supported banks list (e.g., '058' for GTBank)")
+    ),
     responses(
         ( status = 200, description = "Account successfully resolved — returns account name and other verification details", body = ResolveAccountResponse),
         ( status = 400, description = "Bad request — invalid bank code, account number format, or missing required parameters", body = ApiErrorResponse),