fix: persist rejoin memory + one-shot 500 milestone - #137
Open
heavygee wants to merge 1 commit into
Open
Conversation
Welcomed IDs were never durable in prod (missing welcomedUsers.json), and hitting exactly 500 humans again on rejoin re-fired the golden VIP welcome. Seed the roster on startup when history exists but the file is empty, record pfp-only welcomes, and mark milestone500 celebrated once. Fixes #136 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
welcomedUsers.jsonmore loudly, seed current human IDs at startup whenwelcomeCount > 0but the file is empty (prod gap that let rejoins look brand-new).milestone500.json; at startup mark it celebrated if the server is already at/past 500 humans.Test plan
npm test(64 passed)welcomedUsers.jsonandmilestone500.jsonFixes #136
Made with Cursor