fix(messaging): serialize array data values as JSON - #9253
Merged
mikehardy merged 1 commit intoSep 1, 2026
Merged
Conversation
mikehardy
approved these changes
Aug 31, 2026
mikehardy
left a comment
Collaborator
There was a problem hiding this comment.
Hey @OskarEichler 👋
Thanks for the PR - this looks like a real problem to me. I ran local Jest/unit plus the android/ios/macos e2e suite against it here and it came out clean. Pending CI, then I'll merge.
Cheers
mikehardy
force-pushed
the
codex/messaging-data-array-serialization
branch
from
September 1, 2026 11:27
a491eda to
3dcd282
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9253 +/- ##
=============================================
+ Coverage 47.23% 68.20% +20.98%
- Complexity 0 2096 +2096
=============================================
Files 248 441 +193
Lines 11603 25163 +13560
Branches 2494 4256 +1762
=============================================
+ Hits 5479 17161 +11682
- Misses 5303 6612 +1309
- Partials 821 1390 +569
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
RemoteMessage.dataentries with JSON, consistently with other object values.Observable behavior correction
[{ id: 1 }]becomes[{"id":1}]instead of[object Object].Why
The public
RemoteMessage.datavalue type accepts objects, and the serializer already JSON-encodes objects. Its explicit array exclusion routed arrays through JavaScript string coercion instead, losing quoting and nested object data before Android's nativeRemoteMessage.Builderreceived it.Verification
[{"id":1},{"id":2}], received[object Object],[object Object].lerna:prepare, JS lint, dependency-cruiser, both TypeScript compiles, API-reference generation, type-parity comparison, andgit diff --checkpass.