fix(app): support arbitrary web storage keys - #9265
Merged
mikehardy merged 1 commit intoSep 1, 2026
Merged
Conversation
mikehardy
approved these changes
Aug 31, 2026
mikehardy
left a comment
Collaborator
There was a problem hiding this comment.
Hey @OskarEichler 👋
Thanks for the PR - this looks like a real problem to me. I ran local Jest/unit plus the android/ios/macos e2e suite against it here and it came out clean. Pending CI, then I'll merge.
Cheers
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9265 +/- ##
============================================
+ Coverage 68.60% 69.05% +0.45%
- Complexity 2096 2097 +1
============================================
Files 403 443 +40
Lines 22710 25522 +2812
Branches 4097 4256 +159
============================================
+ Hits 15579 17622 +2043
- Misses 5725 6525 +800
+ Partials 1406 1375 -31
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mikehardy
force-pushed
the
codex/app-web-safe-key-storage
branch
from
September 1, 2026 11:55
80afb37 to
44a3dfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
hasOwnPropertyfrom replacing the listener map method and crashing subsequent listener operations.__proto__instead of silently losing them through JavaScript prototype behavior.eventsGetListeners()callers from mutating the internal listener registry.These names are valid strings at the bridge boundary and native maps already support them.
Implementation
The web shim now stores string-keyed data in null-prototype dictionaries, performs explicit own-property checks, and returns detached null-prototype snapshots.
Verification
Exact baseline regressions failed with a TypeError and a lost preference value. All permanent focused cases now pass. Complete repository gates also pass:
yarn lerna:prepareyarn tests:jest --runInBand— 103 suites, 1,482 tests, 31 snapshotsyarn tsc:compileyarn tsc:compile:consumeryarn lint:depsyarn reference:apiyarn compare:typesgit diff --checkCompatibility
No public API/type or breaking change. Ordinary event and preference keys retain their existing behavior.