Skip to content

fix(ci): revert failed 26.3.3 release; stage test-expo pins - #9273

Merged
mikehardy merged 2 commits into
mainfrom
fix/publish-test-expo-stage
Sep 1, 2026
Merged

fix(ci): revert failed 26.3.3 release; stage test-expo pins#9273
mikehardy merged 2 commits into
mainfrom
fix/publish-test-expo-stage

Conversation

@mikehardy

Copy link
Copy Markdown
Collaborator

Summary

  • Reverts the incomplete chore(release): release packages commit (d11b94f80 / attempted v26.3.3) so package versions return to 26.3.2 and the next publish cycle can mint 26.3.3 cleanly.
  • Stages test-expo/package.json (and the other synced test-app manifests) in scripts/version.js during lerna version. test-expo is a Yarn workspace but not a lerna package, so the pin sync left a dirty tree and lerna publish failed with EUNCOMMIT M test-expo/package.json (Publish run).

Remote tag v26.3.3 was already deleted so the version is free for the next Publish workflow run after this merges.

Test plan

  • Confirm lerna.json / package versions on this branch are 26.3.2
  • Confirm scripts/version.js git adds tests, tests-macos, and test-expo package.json after sync
  • After merge, re-run Publish; expect v26.3.3 release commit to include test-expo/package.json and npm publish to succeed

test-expo is a Yarn workspace but not a lerna package, so version.js pin
sync left it dirty and blocked publish after the release commit.

@mikehardy mikehardy left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the revert is easy to judge -> +1
the version.js change looks good and should solve the problem from last (failed) publish:

https://github.com/invertase/react-native-firebase/actions/runs/33457702080/job/99701095633#step:10:1466

@mikehardy
mikehardy merged commit 075f63e into main Sep 1, 2026
16 of 23 checks passed
@mikehardy
mikehardy deleted the fix/publish-test-expo-stage branch September 1, 2026 01:39
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.87%. Comparing base (fecb129) to head (354eb2b).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9273      +/-   ##
============================================
- Coverage     68.53%   67.87%   -0.65%     
+ Complexity     1915     1914       -1     
============================================
  Files           522      382     -140     
  Lines         38151    22324   -15827     
  Branches       5189     4034    -1155     
============================================
- Hits          26142    15150   -10992     
+ Misses        10223     5793    -4430     
+ Partials       1786     1381     -405     
Flag Coverage Δ
android-native 63.75% <ø> (-<0.01%) ⬇️
e2e-ts-android 53.94% <ø> (-0.05%) ⬇️
e2e-ts-ios ?
e2e-ts-macos ?
ios-native ?
ios-ruby ?
jest 46.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant