Skip to content

feat(app, sdk): bump Firebase iOS SDK to 13.1.0 - #9389

Merged
mikehardy merged 7 commits into
mainfrom
feat/bump-ios-sdk-13.1.0
Oct 23, 2026
Merged

mikehardy merged 7 commits into
mainfrom
feat/bump-ios-sdk-13.1.0

Conversation

@mikehardy

Copy link
Copy Markdown
Collaborator

Summary

  • Bump sdkVersions.ios.firebase 13.0.0 → 13.1.0 (upstream firebase-ios-sdk 13.1.0, 2026-10-21).
  • Sync SPM exact pins: packages/app/ios/RNFBFirebase/Package.swift, tests/ios + test-rn-bare Xcode project references.
  • Docs: docs/ios-spm.mdx “currently” + docs/index.mdx $FirebaseSDKVersion / FIREBASE_SDK_VERSION examples.

Test plan

  • Local yarn test:full --slot 5 ALL_PASSED on tip including Package.swift sync (LOGDIR=/tmp/rnfb-full-6RVPtO, tip 5cb9e456f; docs example commit follows).
  • CI green (docs.page CLI → rnfirebase.io non-browser 500s accepted as infra flake for this queue).

@mikehardy

Copy link
Copy Markdown
Collaborator Author

Local qualify: yarn test:full --slot 5 ALL_PASSED (LOGDIR=/tmp/rnfb-full-6RVPtO) on tip including Package.swift sync (5cb9e456f). Follow-up docs commit 25b03b2f6 aligns docs/index.mdx override examples with 13.1.0.

Author cannot self-approve — needs a second maintainer review (or admin merge when CI is otherwise green). docs.page CLI → rnfirebase.io non-browser 500s accepted as infra flake for this queue.

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.09%. Comparing base (1d28f07) to head (6bcc003).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9389      +/-   ##
============================================
- Coverage     75.10%   75.09%   -0.00%     
  Complexity     2298     2298              
============================================
  Files           620      620              
  Lines         41243    41243              
  Branches       5242     5242              
============================================
- Hits          30970    30969       -1     
  Misses         8694     8694              
- Partials       1579     1580       +1     
Flag Coverage Δ
android-native 70.69% <ø> (ø)
e2e-ts-android 53.57% <ø> (ø)
e2e-ts-ios 52.99% <ø> (ø)
e2e-ts-macos 49.31% <ø> (-<0.01%) ⬇️
ios-native 79.08% <ø> (ø)
ios-ruby 100.00% <ø> (ø)
jest 51.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mikehardy mikehardy added Workflow: Pending Merge Waiting on CI or similar and removed Needs Attention labels Oct 22, 2026
Raise timeout-minutes 60→90. Include packages/app/package.json in path
filters and ccache hash (expo-link-ios-v2) so sdkVersions.ios.firebase
pin bumps alone trigger and invalidate the compile cache.
Post-cache re-hash walked node_modules and broad ios trees after yarn/Pods,
hitting GHA's hashFiles limit. Constrain globs to fixture roots, RNFB/generated
app sources, and plugin; exclude UnitTests build artifacts. Applies to rn-bare
(shipped + dynfb) and expo-link ccache keys (v2/v3 bump).
@mikehardy

Copy link
Copy Markdown
Collaborator Author

Pushed CI follow-ups on tip 1a765f931:

  • ci(expo): raise link+launch timeout-minutes 60→90; include packages/app/package.json in paths/ccache for iOS SDK pin bumps
  • ci: narrow Xcode ccache hashFiles (rn-bare + expo) to avoid Post-cache 120s timeouts after yarn/Pods

Will admin rebase-merge when product checks are green (docs.page/rnfirebase.io non-browser 500s still accepted as infra flake).

iOS release Post-cache hit the same hashFiles 120s limit on packages/*/ios/**
after UnitTests/build trees exist. Constrain to RNFB*/generated/plugin and
exclude **/build/**; bump e2e ios/archive/macos cache key versions.
@mikehardy

Copy link
Copy Markdown
Collaborator Author

Follow-up tip 39483e8c6: same Post-cache hashFiles timeout hit tests_e2e_ios.yml after Detox release launch flake (packages/*/ios/**). Narrowed e2e iOS/archive + macos ccache keys like rn-bare/expo.

Note: prior tip already had test-rn-bare and test-expo green; iOS debug green; iOS release Detox launch looked flaky (liveMetro=false, launchApp timeouts) then Post-cache also failed.

Post-cache re-evaluation of hashFiles still exceeded 120s on the dynfb
job after narrowing globs; hash tracked sources once via git ls-files so
Post can reuse the step output.
@mikehardy
mikehardy merged commit 191181e into main Oct 23, 2026
25 of 27 checks passed
@mikehardy
mikehardy deleted the feat/bump-ios-sdk-13.1.0 branch October 23, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant