feat(grpc): add dedicated _masked query methods - #1254
Open
DaughterOfMars wants to merge 1 commit into
Open
Conversation
Alex6323
approved these changes
Jul 16, 2026
Contributor
|
looks good except for the conflicts of course :) |
DaughterOfMars
force-pushed
the
feat/grpc-masked-methods
branch
2 times, most recently
from
July 27, 2026 07:01
e9183b3 to
1cfbf88
Compare
DaughterOfMars
force-pushed
the
feat/grpc-masked-methods
branch
from
August 4, 2026 07:24
1cfbf88 to
8c9dbd4
Compare
Splits each gRPC query endpoint into two methods: the plain method uses the endpoint's default read mask, and a new `_masked` variant takes an explicit typed mask (`impl Into<XxxReadMask>`), so a bare field, slice, array, or vec of fields can be passed without wrapping. The default methods drop their read-mask parameter; internal callers use the `_masked` variants where a custom mask is required. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> fix docs
DaughterOfMars
force-pushed
the
feat/grpc-masked-methods
branch
from
August 7, 2026 09:42
f7b3086 to
9a126b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #1147. Stacked on #1253 — review/merge that one first; this PR's diff is only the
_maskedsplit.Why
Adds ergonomic, mask-explicit variants of the gRPC query methods so callers can pass a bare field / slice / array / vec of fields without wrapping in a
XxxReadMask.What
Splits each query endpoint into two methods:
_maskedvariant takes an explicitimpl Into<XxxReadMask>.Internal callers (
transaction_builder_client, examples) use the_maskedvariants where a custom mask is required.Test plan
cargo check/clippy -Dwarningsclean foriota-sdk-grpc-client(+ tests) andiota-sdk --features grpc --examples.cargo test --docpasses.🤖 Generated with Claude Code