chore: bump the localnet binary used in CI to v1.31.1-rc - #1453
Merged
Conversation
Member
|
Let's at least wait for today's release to bump this to an RC |
The committed GraphQL schema is generated from the 1.31.1 line, so the pinned v1.29.0 node cannot serve 16 of the fields the client is compiled against, and any test touching one fails against it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
thibault-martinez
force-pushed
the
chore/bump-ci-localnet-binary
branch
from
September 2, 2026 12:54
fc8a9b1 to
98622ed
Compare
thibault-martinez
changed the title
v1.31.1-betav1.31.1-rc
Thoralf-M
approved these changes
Sep 2, 2026
thibault-martinez
approved these changes
Sep 2, 2026
Alex6323
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the localnet CI action at
v1.31.1-rcinstead ofv1.29.0.The committed
schema.graphqlis generated from the 1.31.1 line — every name in it exists in that release, while 16 are missing from v1.29.0 (affectedAddress,transactionsByDigests, theAFFECTEDrelation, the deny-rules and disabled-feature flags). Any test touching one fails against the pinned node, so the client can be compiled against fields CI cannot exercise. #1450 and #1452 are both red for exactly this reason.The trade-off worth a second opinion: v1.31.1-rc is a pre-release, so CI would track a node ahead of mainnet (v1.30.1). Keeping v1.29.0 instead means no test can cover anything added to the schema since — including the two PRs above.
🤖 Generated with Claude Code