Skip to content

Use 'go list' directly to avoid an external 'jq' dependency in codegen script - #1540

Merged
adracus merged 1 commit into
ironcore-dev:mainfrom
opensovereigncloud:osc/fix/remove_jq_dependancy
Aug 18, 2026
Merged

adracus merged 1 commit into
ironcore-dev:mainfrom
opensovereigncloud:osc/fix/remove_jq_dependancy

Conversation

@ushabelgur

@ushabelgur ushabelgur commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

  • Use 'go list' directly to avoid an external 'jq' dependency in codegen script

Ref to recent to ironcore-net PR: ironcore-dev/ironcore-net#532 (comment)

Summary by CodeRabbit

  • Chores
    • Simplified module permission updates by removing the requirement for the external jq utility.
    • Preserved recursive permission updates for configured modules.

Signed-off-by: ushabelgur <usha.belgur@t-systems.com>
@ushabelgur
ushabelgur requested a review from a team as a code owner August 18, 2026 09:32
@github-actions github-actions Bot added the bug Something isn't working label Aug 18, 2026
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 965ed0a4-3543-46d7-9170-ca956054d59b

📥 Commits

Reviewing files that changed from the base of the PR and between 048040a and 0c87fe2.

📒 Files selected for processing (1)
  • hack/update-codegen.sh

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The code generation script now resolves module directories with go list -m -f '{{.Dir}}' and removes its jq dependency. It preserves recursive chmod 644 behavior.

Changes

Code generation permissions

Layer / File(s) Summary
Direct module directory resolution
hack/update-codegen.sh
The script uses direct Go module directory output instead of a JSON and jq pipeline before recursively applying chmod 644.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 0c87f

This localized codegen script change removes an external jq dependency without any supplied indication of correctness, deployment, or runtime impact; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: afritzler

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: using go list to remove the external jq dependency from the codegen script.
Description check ✅ Passed The description explains the main change and includes the Proposed Changes section; the optional issue reference is not provided.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@adracus
adracus merged commit 0369ab0 into ironcore-dev:main Aug 18, 2026
11 checks passed
@hardikdr hardikdr added the area/iaas Issues related to IronCore IaaS development. label Aug 21, 2026
@hardikdr hardikdr added this to Roadmap Aug 22, 2026
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/iaas Issues related to IronCore IaaS development. bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants