Add mutating admission policy RBAC to apiserver role - #1550
Conversation
Signed-off-by: Lukas Frank <lukas.frank@sap.com>
f3847cf to
a508be4
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe apiserver ClusterRole now grants get, list, and watch access to ChangesAdmission policy RBAC
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized RBAC change grants the apiserver read access to the required mutating admission policy resources; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description uses the Proposed Changes section, identifies the exact resources and permissions, and explains the Kubernetes 1.36 readiness impact. The optional issue reference is not provided, but the description is otherwise complete and relevant. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed Changes
mutatingadmissionpoliciesandmutatingadmissionpolicybindings(get/list/watch) to theapiserver-roleClusterRole.MutatingAdmissionPolicy/MutatingAdmissionPolicyBindingare served as GA (admissionregistration.k8s.io/v1). The aggregated apiserver's admissioninformers now watch them; without the RBAC grant the informers hit
forbiddenerrors and never sync, so theinformer-syncreadyz check fails and the apiserver pod never becomesReady.
Summary by CodeRabbit