Add hostname propagation to ironcore-net NetworkInterfaces

[ushabelgur]

Proposed Changes

• Pass machineName as hostaname to ironcore-net NetworkInterfaces while creating machine
• Update testcase
• Update ironcore-net dependency

Fixes #538

Summary by CodeRabbit

• New Features

  • Machines can include an optional guest configuration with a hostname; network interfaces now receive and use hostnames from machine guest config to improve identification.

• Chores

  • Bumped Go toolchain and dependency versions and updated pinned tooling versions used for code generation and tests.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds a MachineGuestConfig with HostName, populates it during machine creation, includes Hostname in APInet NetworkInterface apply, and updates Go/Kubernetes dependencies and pinned tool versions.

Changes

Hostname propagation

Layer / File(s)	Summary
API type and machine creation api/machine.go, internal/server/machine_create.go	Adds MachineGuestConfig (HostName JSON hostName,omitempty) to MachineSpec and sets api.MachineSpec.GuestConfig from iriMachine.Spec.GuestConfig.Hostname when creating machines.
APInet plugin apply internal/plugins/networkinterface/apinet/apinet.go	APInet apply-configuration builder now includes Hostname from machine.Spec.GuestConfig.HostName, uses apinetClient.Apply(...), then retrieves the applied NetworkInterface with Get(...) before computing host device/direct wiring.
Dependency upgrades (go.mod) go.mod	Bump go directive and multiple direct/indirect dependencies including github.com/ironcore-dev/ironcore and k8s.io/* / sigs.k8s.io/controller-runtime versions.
Pinned tool versions Makefile	Update CONTROLLER_TOOLS_VERSION and ENVTEST_VERSION defaults used for codegen and envtest downloads.

Sequence Diagram

sequenceDiagram
    participant Client
    participant MachineCreate as Machine Create
    participant APISpec as NetworkInterfaceSpec
    participant APINETPlugin as APINet Plugin
    participant IronNetAPI as IronCore-Net API

    Client->>MachineCreate: Create Machine request
    MachineCreate->>APISpec: Construct NetworkInterfaceSpec
    MachineCreate->>APISpec: Set HostName (from GuestConfig.Hostname)
    MachineCreate->>APINETPlugin: Request NIC creation with Spec
    APINETPlugin->>APISpec: Read HostName from Spec
    APINETPlugin->>IronNetAPI: Apply NetworkInterface (includes Hostname)
    IronNetAPI->>APINETPlugin: Return applied NetworkInterface
    APINETPlugin->>IronNetAPI: Get applied NetworkInterface
    APINETPlugin->>MachineCreate: Return result
    MachineCreate->>Client: Respond Machine created

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: adding hostname propagation to ironcore-net NetworkInterfaces, which is the primary objective of the PR.
Description check	✅ Passed	The description covers the key changes (hostname propagation, test updates, dependency updates) and references the linked issue #538, following the template structure.
Linked Issues check	✅ Passed	The PR satisfies issue #538 requirements: adds hostname field to ironcore-net NetworkInterface via MachineGuestConfig, implements hostname propagation in the apinet plugin, and updates dependencies.
Out of Scope Changes check	✅ Passed	All changes are directly related to hostname propagation: API types for guest config, apinet plugin implementation, machine creation logic, and dependency/tool version updates. No unrelated changes detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch enh/hostname

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

internal/server/machine_create.go (1)

57-67: ⚠️ Potential issue | 🔴 Critical

HostName field will be empty string because iriMachine.Metadata.Id is not populated in requests.

At line 64, the HostName is set to iriMachine.Metadata.Id, but the IRI request's Metadata object never includes an Id field—it's only present in the response after being generated by the server. All test cases confirm that incoming Machine.Metadata contains only labels, not an id.

The PR objective states "Pass machineName as hostname," but the IRI Machine request provides no machine name field. The available option in the request is the Labels map (which contains a UID label, not a human-readable name). The server's generated internal ID at line 71 comes too late and is not the IRI machine's identifier anyway.

To fix this: determine whether to use a label value (if machine name is stored there), or reconsider the approach for obtaining the machine identifier at the point where NetworkInterfaceSpec is created.

[afritzler]

[afritzler]

/ref ironcore-dev/ironcore#1454