Commit bc0b2fc
The write-path warning is recalibrated to what the evidence actually shows
Stephen: "i have no users id'ing this as a problem (file content not being
correct)." He is right, and the absence is evidence rather than missing evidence --
a one-bit shift is not subtle. It makes text unreadable and binary structures
obviously malformed, so anyone affected while writing ordinary files would have said
so at once.
Our own record says the same thing quantitatively. Each release was verified by 27
regression binaries, each carrying its own hub layout, running thousands of sector
writes with independent byte-level content verification -- verifyBufferPattern
regenerates the expected sequence rather than comparing a buffer to itself. Across 18
releases none landed on the failing side. The defect surfaced only when an unrelated
commit shifted the layout mid-development. If the failing region were anything like
the naive one-in-seven the phase arithmetic suggests, roughly four suites would have
been red in every release for four months.
So the previous wording was disproportionate. It told users their data may be wrong
and to verify everything against a backup or rewrite it -- proportionate to a defect
that hits often, not to one whose failing layout region is demonstrably small. Over-
warning is not the safe side: it alarms people who were never affected, invites
needless rewriting of good data, and spends credibility a future genuine warning will
need.
Both notes now lead with the likelihood, give the evidence for it, and keep the
disclosure. The check is proportionate too -- open a file and look at it, which
settles it for most data in a minute; a backup comparison only for data that is both
opaque and irreplaceable.
One outright error fixed while there. The old text was headed "Why you cannot have
noticed", which is false -- the user very likely WOULD have noticed. That claim was
about the DRIVER's two checks, not the reader's eyes, and it now says so.
The honest caveat is kept and made explicit rather than implied: our binaries are
harnesses, the user's is their application plus this driver, sampling a layout we
never did. That is why the note exists at all instead of "it never affected anyone".
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent c14be8d commit bc0b2fc
2 files changed
Lines changed: 53 additions & 33 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
58 | 58 | | |
59 | | - | |
60 | | - | |
61 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
62 | 62 | | |
63 | | - | |
| 63 | + | |
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
18 | 22 | | |
19 | 23 | | |
20 | 24 | | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
25 | 47 | | |
26 | | - | |
27 | | - | |
| 48 | + | |
| 49 | + | |
28 | 50 | | |
29 | 51 | | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
50 | 70 | | |
51 | 71 | | |
52 | 72 | | |
| |||
0 commit comments