improve docstrings

Signed-off-by: zhx06 <zihaox@nvidia.com>

Author: zhx06

isaaclab_arena/environments/arena_env_builder.py

@@ -36,11 +36,7 @@
 )
 from isaaclab_arena.recording.common_terms import CoreEpisodeRecorderTermCfg, VariationEpisodeRecorderTermCfg
 from isaaclab_arena.recording.episode_recorder_manager import EpisodeRecorderTermCfg
-<<<<<<< HEAD
 from isaaclab_arena.recording.progress_terms import ProgressEpisodeRecorderTermCfg
-from isaaclab_arena.relations.collision_mode import CollisionMode
-=======
->>>>>>> a690c8f59 (address comments)
 from isaaclab_arena.relations.object_placer_params import ObjectPlacerParams
 from isaaclab_arena.relations.placement_events import PLACEMENT_RESET_EVENT_NAME
 from isaaclab_arena.tasks.no_task import NoTask

isaaclab_arena/relations/relation_solver.py

@@ -521,7 +521,7 @@ def _compute_no_overlap_loss_mesh(
                         device=device,
                     )
 
-                # AABB broadphase (yaw-aware): skip separated pairs.
+                # AABB overlap filter (yaw-aware): skip separated pairs.
                 margins = cache.pair_max_radius + clearance_m
                 s_bbox_min = cache.pair_subject_bbox_min[:, b, :]
                 s_bbox_max = cache.pair_subject_bbox_max[:, b, :]
@@ -664,8 +664,6 @@ def solve(
                         on_pairs.add((id(rel.parent), id(obj)))
             self._mesh_orientations = orientations
             self._prepare_mesh_collision_cache(state, on_pairs)
-
-        if self.params.collision_mode == CollisionMode.MESH:
             self._mesh_manager.reset_sentinel_warning()
 
         # Setup optimizer (only for optimizable positions)
@@ -688,7 +686,7 @@ def solve(
             loss = self._compute_total_loss(state)
             loss_history.append(loss.item())
 
-            # Constant-zero loss has no grad_fn — skip backward when broadphase culls all pairs.
+            # Constant-zero loss has no grad_fn — skip backward when overlap filter culls all pairs.
             if loss.grad_fn is not None:
                 loss.backward()
                 optimizer.step()

isaaclab_arena/relations/warp_sdf_kernels.py

@@ -119,7 +119,7 @@ def sdf_sentinel_count(sdf_values: torch.Tensor) -> int:
 
 
 def clamp_sdf_sentinel(sdf_values: torch.Tensor) -> torch.Tensor:
-    """Replace sentinel SDF values with 0 (treat as "on surface") so they produce gradient."""
+    """Replace sentinel SDF values with 0 so no-face hits contribute zero loss rather than large positive."""
     return torch.where(sdf_values >= _SDF_SENTINEL, torch.zeros_like(sdf_values), sdf_values)