Skip to content

Add greptile.json: review non-draft PRs once, not per commit - #852

Merged
qianl-nv merged 3 commits into
mainfrom
cvolkcvolk/chore/greptile-review-config
Jul 3, 2026
Merged

Add greptile.json: review non-draft PRs once, not per commit#852
qianl-nv merged 3 commits into
mainfrom
cvolkcvolk/chore/greptile-review-config

Conversation

@cvolkcvolk

@cvolkcvolk cvolkcvolk commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Configure Greptile to review each PR once (on open / ready-for-review) instead of on every commit, and to skip drafts.

  • triggerOnUpdates: false — no re-review on new commits (Greptile defaults this on); the initial review still happens.
  • triggerOnDrafts: false — do not review draft PRs (Greptile default; set explicitly).
  • Keeps review noise to one pass per PR, matching how we want the repo's review bots to behave.

Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Comment thread greptile.json
@arena-review-bot

Copy link
Copy Markdown
Contributor

🤖 Isaac Lab-Arena Review Bot

Summary

This PR adds a 4-line repo-root greptile.json so Greptile reviews a PR once (on open / ready-for-review) rather than on every commit, and skips drafts. This is an infra change affecting the review bot for every contributor, but it is small, intentional, and uses valid config keys — I verified both triggerOnDrafts and triggerOnUpdates against Greptile's official greptile.json reference.

Findings

🔵 Improvement: greptile.json:3 — Greptile's current reference lists the default for both keys as false, which contradicts the PR description's claim that triggerOnUpdates "defaults this on." Since the repo was empirically reviewing on every commit, that behavior likely came from a dashboard/org-level Greptile setting rather than the file default. Worth confirming this repo-root file actually overrides that setting (otherwise it's a no-op); if it does, explicitly pinning both is fine and guards against a future default change.

Test Coverage

Not applicable — config-only change, no code paths to test.

Verdict

Ship it — small, intentional infra config with valid keys. Just confirm the file takes effect over any dashboard-level Greptile setting, and consider correcting the "defaults on" wording in the PR description.

@greptile-apps

greptile-apps Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds a greptile.json configuration file to control when Greptile reviews are triggered, limiting reviews to one pass per PR instead of re-reviewing on every commit.

  • triggerOnDrafts: false — skips reviews on draft PRs (matches the Greptile default but is set explicitly).
  • triggerOnUpdates: false — prevents re-review on new commits; the initial review on PR open or ready-for-review still fires.

Confidence Score: 5/5

Safe to merge — adds a small, well-documented Greptile config file with no impact on application code or CI.

The change is a 4-line JSON config file that only affects when Greptile reviews are triggered. Both settings are straightforward and correctly match the described intent; there is no application logic, no migrations, and no side effects on the codebase itself.

No files require special attention.

Important Files Changed

Filename Overview
greptile.json New Greptile configuration file setting triggerOnDrafts and triggerOnUpdates to false — minimal, intentional change with no logic impact.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR Event] --> B{Is Draft?}
    B -- Yes --> C[Skip Review\ntriggerOnDrafts: false]
    B -- No --> D{Is it an update\nto existing PR?}
    D -- Yes --> E[Skip Review\ntriggerOnUpdates: false]
    D -- No --> F[PR Opened /\nReady for Review]
    F --> G[Greptile Reviews Once]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[PR Event] --> B{Is Draft?}
    B -- Yes --> C[Skip Review\ntriggerOnDrafts: false]
    B -- No --> D{Is it an update\nto existing PR?}
    D -- Yes --> E[Skip Review\ntriggerOnUpdates: false]
    D -- No --> F[PR Opened /\nReady for Review]
    F --> G[Greptile Reviews Once]
Loading

Reviews (3): Last reviewed commit: "Remove temporary greptile test file" | Re-trigger Greptile

…moved)

Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Comment thread .greptile-update-test Outdated
Signed-off-by: Clemens Volk <cvolk@nvidia.com>

@qianl-nv qianl-nv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change quickly!

@qianl-nv
qianl-nv merged commit b28ebec into main Jul 3, 2026
22 of 25 checks passed
@qianl-nv
qianl-nv deleted the cvolkcvolk/chore/greptile-review-config branch July 3, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants