Skip to content

Commit 0fa4d34

Browse files
committed
Default zero agent to Newton visualizer
1 parent 4f15463 commit 0fa4d34

3 files changed

Lines changed: 21 additions & 2 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
Changed
2+
^^^^^^^
3+
4+
* Changed the zero agent to use the Newton GL visualizer by default. Pass ``--viz kit`` to keep using the Kit
5+
visualizer.

source/isaaclab_rl/isaaclab_rl/entrypoints/simple_agents.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,8 +245,8 @@ def _parse_args(argv: list[str] | None, policy: PolicyName) -> argparse.Namespac
245245
)
246246
# append AppLauncher cli args
247247
add_launcher_args(parser)
248-
# simple agents should open Kit visualizer by default
249-
parser.set_defaults(visualizer=["kit"])
248+
# Keep the zero agent on the kitless default path while preserving the random-agent behavior.
249+
parser.set_defaults(visualizer=["newton_gl"] if policy == "zero" else ["kit"])
250250
args_cli, hydra_args = setup_preset_cli(parser, argv)
251251
sys.argv = [sys.argv[0]] + hydra_args
252252
return args_cli

source/isaaclab_rl/test/test_entrypoints.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,20 @@ def test_zero_agent_supports_direct_multi_agent_action_spaces() -> None:
184184
assert torch.equal(actions["object"], torch.zeros(3, 1, dtype=torch.int64))
185185

186186

187+
@pytest.mark.parametrize(("policy", "expected_visualizer"), [("zero", ["newton_gl"]), ("random", ["kit"])])
188+
def test_simple_agent_default_visualizer_depends_on_policy(
189+
policy: _simple_agents.PolicyName,
190+
expected_visualizer: list[str],
191+
monkeypatch: pytest.MonkeyPatch,
192+
) -> None:
193+
"""The zero agent defaults to Newton visualization without changing the random agent."""
194+
monkeypatch.setattr(sys, "argv", ["pytest"])
195+
196+
args = _simple_agents._parse_args([], policy)
197+
198+
assert args.visualizer == expected_visualizer
199+
200+
187201
def test_zero_agent_rejects_invalid_config_before_launch(monkeypatch: pytest.MonkeyPatch) -> None:
188202
"""Unsupported task presets fail cleanly before a simulator backend is initialized."""
189203

0 commit comments

Comments
 (0)