Skip to content

Commit 1a1a931

Browse files
committed
Update changelog fragments for the Shadow Hand tendon work
1 parent f281737 commit 1a1a931

3 files changed

Lines changed: 20 additions & 25 deletions

File tree

source/isaaclab_assets/changelog.d/codex-shadow-hand-unified-asset.minor.rst

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ Changed
66
named differently. Both engines now spawn the hand at the same orientation; the previous assets
77
needed two, because one baked a root orientation that the other did not.
88

9+
* Changed ``SHADOW_HAND_CFG`` to spawn the asset with its default ``Physics`` variant. Use
10+
``SHADOW_HAND_PHYSX_CFG`` or ``SHADOW_HAND_NEWTON_CFG`` to select an engine explicitly.
11+
912
Added
1013
^^^^^
1114

@@ -18,11 +21,11 @@ Added
1821
Removed
1922
^^^^^^^
2023

21-
* Removed ``SHADOW_ACTUATED_JOINT_NAMES``, ``SHADOW_TENDON_JOINT_NAMES`` and
22-
``SHADOW_PHYSX_TENDON_GEARING``. Use ``JOINT_NAMES`` and
23-
``TENDON_NAMES`` instead. Note that ``SHADOW_ACTUATED_JOINT_NAMES`` listed all
24-
twenty motors, so code that fed it to ``find_joints`` was asking for four joints that do not
25-
exist; ``JOINT_NAMES`` lists only the sixteen that drive a joint.
24+
* Removed ``SHADOW_ACTUATED_JOINT_NAMES``; use ``JOINT_NAMES`` for the sixteen joint-driving
25+
motors and ``TENDON_NAMES`` for the four tendon-driving ones. The removed list named all twenty
26+
motors, so code that fed it to ``find_joints`` was asking for four joints that do not exist.
27+
28+
* Removed ``SHADOW_FINGERTIP_BODY_NAMES``; use ``FINGERTIP_NAMES``.
2629

2730
Fixed
2831
^^^^^

source/isaaclab_newton/changelog.d/codex-shadow-hand-unified-asset.minor.rst

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2,28 +2,12 @@ Added
22
^^^^^
33

44
* Added a view over MuJoCo's native fixed-tendon position actuators, so a tendon imported from a
5-
MuJoCo-authored asset can be commanded directly instead of through the joints it spans.
5+
MuJoCo-authored asset can be commanded directly instead of through the joints it spans. Actuators
6+
are paired with tendons by their target; a tendon without an actuator is named in a start-up
7+
warning and commands to it have no effect.
68

79
Fixed
810
^^^^^
911

10-
* Fixed MuJoCo-authored USD assets losing every ``mjc:*`` attribute on import. The attributes are
11-
read only when the MuJoCo solver's custom attributes are registered on the model builder before
12-
the stage is traversed, so joint armature, joint friction and actuator definitions silently fell
13-
back to their schema defaults.
14-
1512
* Fixed :attr:`~isaaclab.assets.articulation.BaseArticulationData.fixed_tendon_pos_limits` raising
16-
``AttributeError`` instead of reporting the tendons' position limits.
17-
18-
* Fixed articulation start-up scanning every actuator in the scene once per tendon, which cost
19-
minutes before the first training step at high environment counts.
20-
21-
* Fixed :meth:`~isaaclab.assets.articulation.BaseArticulation.set_fixed_tendon_position_target_index`
22-
ignoring ``env_ids`` on Newton. A command for a subset of environments was sized against every
23-
instance and raised, where PhysX applied it to the environments given.
24-
25-
* Fixed Newton tendon commands interpreting fixed-tendon IDs as IDs in a filtered list of direct
26-
MuJoCo actuators, so a tendon ID addressed a different tendon than the one
27-
:meth:`~isaaclab.assets.articulation.BaseArticulation.find_fixed_tendons` named. Commands now use
28-
the articulation's fixed-tendon index space, and any tendon without a direct position actuator is
29-
named in a warning at start-up; commanding one has no effect.
13+
``AttributeError`` on Newton. It is now bound to ``mujoco.tendon_range``.

source/isaaclab_physx/changelog.d/codex-shadow-hand-unified-asset.rst

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
Changed
2+
^^^^^^^
3+
4+
* Changed fixed tendons to be named after their ``PhysxTendonAxisRootAPI`` instance rather than the
5+
joint prim carrying it, matching OVPhysX and Newton. Code that looked a tendon up by its joint
6+
name, through ``find_fixed_tendons`` or ``SceneEntityCfg.fixed_tendon_names``, must use the
7+
instance name.
8+
19
Fixed
210
^^^^^
311

0 commit comments

Comments
 (0)